All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Kennedy <richard@rsk.demon.co.uk>
To: Jens Axboe <jens.axboe@oracle.com>,
	Vivek Goyal <vgoyal@redhat.com>,
	Corrado Zoccolo <czoccolo@gmail.com>,
	Jeff Moyer <jmoyer@redhat.com>,
	Gui Jianfeng <guijianfeng@cn.fujitsu.com>
Cc: lkml <linux-kernel@vger.kernel.org>
Subject: [PATCH] cfq: reorder cfq_queue removing padding on 64bit & allowing more objects/slab in it's kmem_cache
Date: Mon, 15 Feb 2010 14:10:36 +0000	[thread overview]
Message-ID: <1266243036.2149.21.camel@localhost> (raw)

This removes 8 bytes of padding from struct cfq_queue on 64 bit builds,
shrinking it's size to 256 bytes, so fitting into 1 fewer cachelines and
allowing 1 more object/slab in it's kmem_cache.
 

Signed-off-by: Richard Kennedy <richard@rsk.demon.co.uk>
----
patch against 2.6.33-rc8
tested on x86_64 AMDX2

regards
Richard


diff --git a/block/cfq-iosched.c b/block/cfq-iosched.c
index 023f4e6..db4c127 100644
--- a/block/cfq-iosched.c
+++ b/block/cfq-iosched.c
@@ -116,10 +116,10 @@ struct cfq_queue {
 	unsigned long dispatch_start;
 	unsigned int allocated_slice;
 	/* time when first request from queue completed and slice started. */
+	unsigned int slice_dispatch;
 	unsigned long slice_start;
 	unsigned long slice_end;
 	long slice_resid;
-	unsigned int slice_dispatch;
 
 	/* pending metadata requests */
 	int meta_pending;
@@ -130,13 +130,13 @@ struct cfq_queue {
 	unsigned short ioprio, org_ioprio;
 	unsigned short ioprio_class, org_ioprio_class;
 
+	pid_t pid;
+
 	unsigned int seek_samples;
 	u64 seek_total;
 	sector_t seek_mean;
 	sector_t last_request_pos;
 
-	pid_t pid;
-
 	struct cfq_rb_root *service_tree;
 	struct cfq_queue *new_cfqq;
 	struct cfq_group *cfqg;



             reply	other threads:[~2010-02-15 14:10 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-15 14:10 Richard Kennedy [this message]
2010-02-15 14:16 ` [PATCH] cfq: reorder cfq_queue removing padding on 64bit & allowing more objects/slab in it's kmem_cache Vivek Goyal
2010-02-15 15:32   ` Richard Kennedy
2010-02-15 16:26   ` [PATCH v2] " Richard Kennedy
2010-02-15 17:01     ` Jeff Moyer
2010-02-22 12:49     ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1266243036.2149.21.camel@localhost \
    --to=richard@rsk.demon.co.uk \
    --cc=czoccolo@gmail.com \
    --cc=guijianfeng@cn.fujitsu.com \
    --cc=jens.axboe@oracle.com \
    --cc=jmoyer@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=vgoyal@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.