From: Artem Bityutskiy <dedekind1@gmail.com>
To: Joakim Tjernlund <joakim.tjernlund@transmode.se>
Cc: linux-mtd@lists.infradead.org
Subject: Re: [PATCH 1/2] jffs:2 Move erasing from write_super to GC.
Date: Tue, 16 Feb 2010 11:45:35 +0200 [thread overview]
Message-ID: <1266313535.11659.203.camel@localhost> (raw)
In-Reply-To: <OFAA60FE5A.4E16F45A-ONC12576CC.003285C2-C12576CC.0033188F@transmode.se>
On Tue, 2010-02-16 at 10:18 +0100, Joakim Tjernlund wrote:
> > Also, I think you should call it with count = 1, so that you would erase
> > only one EB at one iteration. This way you will let the GC thread do
> > other things with less latency as well.
>
> If we reduce the count to 1 one might just as well remove count from
> jffs2_erase_pending_blocks() and make it just erase one block on each invocation,
> not sure I like that as it will be more overhead when erasing many blocks.
>
> I figure erasing blocks is the most rewarding form of GC so there should
> be no need to reduce latency for other things, can you think of a reason?
Hmm, yes, you are right. Please, discard my "erase only 1" suggestion.
--
Best Regards,
Artem Bityutskiy (Артём Битюцкий)
next prev parent reply other threads:[~2010-02-16 9:46 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-15 16:03 [PATCH 1/2] jffs:2 Move erasing from write_super to GC Joakim Tjernlund
2010-02-15 16:03 ` [PATCH 2/2] s/jffs2_erase_pending_trigger/jffs2_garbage_collect_trigger/ Joakim Tjernlund
2010-02-16 8:59 ` Artem Bityutskiy
2010-02-16 9:32 ` Joakim Tjernlund
2010-02-16 14:27 ` Joakim Tjernlund
2010-02-17 7:18 ` Artem Bityutskiy
2010-02-17 7:35 ` Joakim Tjernlund
2010-02-17 7:48 ` Artem Bityutskiy
2010-02-17 7:55 ` Joakim Tjernlund
2010-02-17 8:07 ` Artem Bityutskiy
2010-02-17 8:19 ` Joakim Tjernlund
2010-02-16 8:57 ` [PATCH 1/2] jffs:2 Move erasing from write_super to GC Artem Bityutskiy
2010-02-16 9:18 ` Joakim Tjernlund
2010-02-16 9:45 ` Artem Bityutskiy [this message]
2010-02-16 11:49 ` Joakim Tjernlund
2010-02-16 11:59 ` Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1266313535.11659.203.camel@localhost \
--to=dedekind1@gmail.com \
--cc=joakim.tjernlund@transmode.se \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.