All of lore.kernel.org
 help / color / mirror / Atom feed
From: jamal <hadi@cyberus.ca>
To: David Miller <davem@davemloft.net>
Cc: adobriyan@gmail.com, netdev@vger.kernel.org
Subject: Re: regression due to "flush SAD/SPD generate false events"
Date: Wed, 17 Feb 2010 18:49:13 -0500	[thread overview]
Message-ID: <1266450553.17794.165.camel@bigi> (raw)
In-Reply-To: <20100217.154009.78177059.davem@davemloft.net>

On Wed, 2010-02-17 at 15:40 -0800, David Miller wrote:

> Please do, your changes are reverted so I need the whole
> thing back.

np.
Q: Something odd i noticed when looking at pfkey (different behavior
from netlink):

pfkey_sendmsg() does at the end:
return err ? : len;

So if err was 0, it will always return the length which is
16 in the flush which was causing the EAGAIN Alexey saw. If i returned
the correct error (ESRCH), it goes unfiltered.
It sounds to me that should just unconditionaly return err, no?

cheers,
jamal


  reply	other threads:[~2010-02-17 23:49 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-17 19:17 regression due to "flush SAD/SPD generate false events" Alexey Dobriyan
2010-02-17 21:42 ` David Miller
2010-02-17 23:34   ` jamal
2010-02-17 23:40     ` David Miller
2010-02-17 23:49       ` jamal [this message]
2010-02-17 23:55         ` David Miller
2010-02-18  0:03           ` jamal
2010-02-17 21:42 ` jamal
2010-02-17 23:07   ` jamal
2010-02-17 23:32     ` jamal
2010-02-18 18:55       ` Alexey Dobriyan
2010-02-18 20:53         ` jamal
2010-02-18 21:45           ` jamal
2010-02-18 22:27             ` David Miller
2010-02-18 22:52               ` jamal
2010-02-18 23:01                 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1266450553.17794.165.camel@bigi \
    --to=hadi@cyberus.ca \
    --cc=adobriyan@gmail.com \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.