From: Artem Bityutskiy <dedekind1@gmail.com>
To: Joakim Tjernlund <Joakim.Tjernlund@transmode.se>
Cc: linux-mtd@lists.infradead.org
Subject: Re: [PATCH 1/2] jffs2: Move erasing from write_super to GC.
Date: Thu, 18 Feb 2010 13:06:06 +0200 [thread overview]
Message-ID: <1266491166.16891.18.camel@localhost> (raw)
In-Reply-To: <1266394581-32450-2-git-send-email-Joakim.Tjernlund@transmode.se>
On Wed, 2010-02-17 at 09:16 +0100, Joakim Tjernlund wrote:
> diff --git a/fs/jffs2/erase.c b/fs/jffs2/erase.c
> index b47679b..1ca2559 100644
> --- a/fs/jffs2/erase.c
> +++ b/fs/jffs2/erase.c
> @@ -114,6 +114,11 @@ void jffs2_erase_pending_blocks(struct jffs2_sb_info *c, int count)
> while (!list_empty(&c->erase_complete_list) ||
> !list_empty(&c->erase_pending_list)) {
>
> + if (signal_pending(current)) {
> + spin_unlock(&c->erase_completion_lock);
> + mutex_unlock(&c->erase_free_sem);
> + goto done;
> + }
Err, I thought you would remove signal checking from this function? It
really does not belong here.
--
Best Regards,
Artem Bityutskiy (Артём Битюцкий)
next prev parent reply other threads:[~2010-02-18 11:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-17 8:16 [PATCH 0/2] Move erasing to the GC thread Joakim Tjernlund
2010-02-17 8:16 ` [PATCH 1/2] jffs2: Move erasing from write_super to GC Joakim Tjernlund
2010-02-17 8:16 ` [PATCH 2/2] jffs2: Make jffs2_erase_pending_trigger() initiate GC Joakim Tjernlund
2010-02-18 11:06 ` Artem Bityutskiy [this message]
2010-02-18 12:17 ` [PATCH 1/2] jffs2: Move erasing from write_super to GC Joakim Tjernlund
2010-02-18 12:22 ` Artem Bityutskiy
2010-02-18 13:12 ` Joakim Tjernlund
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1266491166.16891.18.camel@localhost \
--to=dedekind1@gmail.com \
--cc=Joakim.Tjernlund@transmode.se \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.