All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marcel Holtmann <marcel@holtmann.org>
To: sjur.brandeland@stericsson.com
Cc: netdev@vger.kernel.org, davem@davemloft.net,
	daniel.martensson@stericsson.com, kaber@trash.net,
	stefano.babic@babic.homelinux.org, randy.dunlap@oracle.com
Subject: Re: [PATCH net-next-2.6 v3 00/12] net-caif: introducing CAIF protocol stack
Date: Tue, 23 Feb 2010 08:33:07 +0100	[thread overview]
Message-ID: <1266910387.18491.54.camel@violet> (raw)
In-Reply-To: <1266876331-23988-1-git-send-email-sjur.brandeland@stericsson.com>

Hi Sjur,

> This patch-set introduces the CAIF protocol Stack.
> The "Communication CPU to Application CPU Interface" (CAIF) is a packet based
> connection-oriented MUX protocol developed by ST-Ericsson for use with its
> modems.
> 
> 
> CHANGE LOG:
> Based on review comments from David Miller and Marcel Holtmann on the 
> previous patch set submitted the 16 February the following changes
> have been done:
> - Removed ifdef __cplusplus from caif_socket.h
> - Use socket level SOL_IP for socket options SO_PRIORITY and SO_BINDTODEVICE

are you sure it is not better to use SOL_SOCKET here. At least according
to man 7 socket this would make a lot more sense. My point in actually
using SO_PRIORITY and SO_BINDTODEVICE is to use standard socket options
that are already used by everybody else. So they know what to expect.

Regards

Marcel



  parent reply	other threads:[~2010-02-23  7:31 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-22 22:05 [PATCH net-next-2.6 v3 00/12] net-caif: introducing CAIF protocol stack sjur.brandeland
2010-02-22 22:05 ` [PATCH net-next-2.6 v3 01/12] net-caif: add CAIF protocol definitions sjur.brandeland
2010-02-22 22:05   ` [PATCH net-next-2.6 v3 02/12] net-caif: add CAIF socket and configuration headers sjur.brandeland
2010-02-22 22:05     ` [PATCH net-next-2.6 v3 03/12] net-caif: add CAIF core protocol stack header files sjur.brandeland
2010-02-22 22:05       ` [PATCH net-next-2.6 v3 04/12] net-caif: add CAIF Link layer device " sjur.brandeland
2010-02-22 22:05         ` [PATCH net-next-2.6 v3 05/12] net-caif: add CAIF core protocol stack sjur.brandeland
2010-02-22 22:05           ` [PATCH net-next-2.6 v3 06/12] net-caif: add CAIF generic caif support functions sjur.brandeland
2010-02-22 22:05             ` [PATCH net-next-2.6 v3 07/12] net-caif: add CAIF device registration functionality sjur.brandeland
2010-02-22 22:05               ` [PATCH net-next-2.6 v3 08/12] net-caif: add CAIF socket implementation sjur.brandeland
2010-02-22 22:05                 ` [PATCH net-next-2.6 v3 09/12] net-caif: add CAIF netdevice sjur.brandeland
2010-02-22 22:05                   ` [PATCH net-next-2.6 v3 10/12] net-caif: add CAIF Kconfig and Makefiles sjur.brandeland
2010-02-22 22:05                     ` [PATCH net-next-2.6 v3 11/12] net-caif: add CAIF documentation sjur.brandeland
2010-02-22 22:05                       ` [PATCH net-next-2.6 v3 12/12] net-caif-driver: add CAIF serial driver (ldisc) sjur.brandeland
2010-02-23  7:33 ` Marcel Holtmann [this message]
2010-02-23  7:39   ` [PATCH net-next-2.6 v3 00/12] net-caif: introducing CAIF protocol stack Sjur Brændeland
2010-02-26  9:22     ` David Miller
2010-02-27 10:05       ` Sjur Brændeland
2010-02-27 10:31         ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1266910387.18491.54.camel@violet \
    --to=marcel@holtmann.org \
    --cc=daniel.martensson@stericsson.com \
    --cc=davem@davemloft.net \
    --cc=kaber@trash.net \
    --cc=netdev@vger.kernel.org \
    --cc=randy.dunlap@oracle.com \
    --cc=sjur.brandeland@stericsson.com \
    --cc=stefano.babic@babic.homelinux.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.