From: Thara Gopinath <thara@ti.com>
To: linux-omap@vger.kernel.org
Cc: Thara Gopinath <thara@ti.com>,
Kevin Hilman <khilman@deeprootsystems.com>
Subject: [PATCH V2] [PM-WIP-OPP]: Fixing wrong target level being passed during Core DVFS.
Date: Tue, 23 Feb 2010 22:33:52 +0530 [thread overview]
Message-ID: <1266944632-9744-1-git-send-email-thara@ti.com> (raw)
As per the current implementaion (u8*)&target_level is being passed
to freq_to_opp in set_opp. This would result in updating just the first
8 bits of a u32 variable. Later target_level is passed to
resource_set_opp_level as a u32 parameter. This maens
a. Initially target_level was 0xabcdefgh.
b. freq_to_opp updates the lower eight bits of target_level
to 0xXX. Now target_level = 0xabcdefXX.
c. We pass 0xabcdefXX as target_level to resource_set_opp_level
when we want to pass just 0xXX.
This is leading to some corrupted bookkeeping later on in the
dvfs path.
This patch ensures that target_level passed to resource_set_opp_level
is actually the level that is intended by freq_to_opp API.
Signed-off-by: Thara Gopinath <thara@ti.com>
Cc: Kevin Hilman <khilman@deeprootsystems.com>
---
arch/arm/mach-omap2/resource34xx.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/arch/arm/mach-omap2/resource34xx.c b/arch/arm/mach-omap2/resource34xx.c
index 3604a38..2c850a2 100644
--- a/arch/arm/mach-omap2/resource34xx.c
+++ b/arch/arm/mach-omap2/resource34xx.c
@@ -478,6 +478,7 @@ int set_opp(struct shared_resource *resp, u32 target_level)
/* uh uh.. no OPPs?? */
BUG_ON(IS_ERR(oppx));
+ target_level = 0;
ret = freq_to_opp((u8 *)&target_level, OPP_L3, req_l3_freq);
/* we dont expect this to fail */
BUG_ON(ret);
--
1.5.4.7
next reply other threads:[~2010-02-23 17:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-23 17:03 Thara Gopinath [this message]
2010-02-23 18:37 ` [PATCH V2] [PM-WIP-OPP]: Fixing wrong target level being passed during Core DVFS Kevin Hilman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1266944632-9744-1-git-send-email-thara@ti.com \
--to=thara@ti.com \
--cc=khilman@deeprootsystems.com \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.