All of lore.kernel.org
 help / color / mirror / Atom feed
From: Feng Yang <fyang@redhat.com>
To: autotest@test.kernel.org
Cc: kvm@vger.kernel.org, Feng Yang <fyang@redhat.com>
Subject: [PATCH] KVM Test: Add check_image script as post_command script of qcow2 variant.
Date: Wed, 24 Feb 2010 18:30:09 +0800	[thread overview]
Message-ID: <1267007409-3379-1-git-send-email-fyang@redhat.com> (raw)

Add check_image.py in scripts folder.  It will performance qemu-img info
and qemu-img check.
Add check_image.py as post command of qcow2 variant.

Signed-off-by: Feng Yang <fyang@redhat.com>
---
 client/tests/kvm/scripts/check_image.py |   96 +++++++++++++++++++++++++++++++
 client/tests/kvm/tests_base.cfg.sample  |    3 +
 2 files changed, 99 insertions(+), 0 deletions(-)
 create mode 100755 client/tests/kvm/scripts/check_image.py

diff --git a/client/tests/kvm/scripts/check_image.py b/client/tests/kvm/scripts/check_image.py
new file mode 100755
index 0000000..f66cd99
--- /dev/null
+++ b/client/tests/kvm/scripts/check_image.py
@@ -0,0 +1,96 @@
+import os, sys, commands
+
+
+class ImageCheckError(Exception):
+    """
+    Simple wrapper for the builtin Exception class.
+    """
+    pass
+
+
+class ImageCheck(object):
+    """
+    Check qcow2 image by qemu-img info/check command.
+    """
+    def __init__(self):
+        """
+        Gets params from environment variables and sets class attributes.
+        """
+        self.image_path_list = []
+        client_dir =  os.environ['AUTODIR']
+        self.kvm_dir = os.path.join(client_dir, 'tests/kvm')
+        img_to_check = os.environ['KVM_TEST_images'].split()
+
+        for img in img_to_check:
+            img_name_str = "KVM_TEST_image_name_%s" % img
+            if not os.environ.has_key(img_name_str):
+                img_name_str = "KVM_TEST_image_name"
+            img_format_str = "KVM_TEST_image_format_%s" % img
+            if os.environ.has_key(img_format_str):
+                image_format = os.environ[img_format_str]
+            else:
+                image_format = os.environ['KVM_TEST_image_format']
+            if image_format != "qcow2":
+                continue
+            image_name = os.environ[img_name_str]
+            image_filename = "%s.%s" % (image_name, image_format)
+            image_filename = os.path.join(self.kvm_dir, image_filename)
+            self.image_path_list.append(image_filename)
+        if os.environ.has_key('KVM_TEST_qemu_img_binary'):
+            self.qemu_img_path = os.environ['KVM_TEST_qemu_img_binary']
+        else:
+            self.qemu_img_path = os.path.join(self.kvm_dir, 'qemu-img')
+        self.qemu_img_check = True
+        cmd = "%s |grep check" % self.qemu_img_path
+        (s1, output) = commands.getstatusoutput(cmd)
+        if s1:
+            self.qemu_img_check = False
+            print "qemu-img check command is not available!"
+        cmd = "%s |grep info" % self.qemu_img_path
+        (s2, output) = commands.getstatusoutput(cmd)
+        if s2:
+            self.qemu_img_check = False
+            print "qemu-img info command is not available!"
+
+    def exec_img_cmd(self, cmd_type, image_path):
+        """
+        Run qemu-img info/check on given image.
+
+        @param cmd_type: Sub command used together with qemu.
+        @param image_path: Real path of the image.
+        """
+        cmd = ' '.join([self.qemu_img_path, cmd_type, image_path])
+        print "checking with %s" % cmd
+        (status, output) = commands.getstatusoutput(cmd)
+        print output
+        if status or (cmd_type == "check" and not "No errors" in output):
+            msg = "Command %s failed" % cmd
+            return False, msg
+        else:
+            return True, ''
+
+
+    def check_image(self):
+        """
+        Run qemu-img info/check to check the image in list.
+
+        If the image checking is failed, raise an exception.
+        """
+        # Check all the image in list.
+        errmsg = []
+        for image_path in self.image_path_list:
+            s, o = self.exec_img_cmd('info', image_path)
+            if not s:
+                errmsg.append(o)
+            s, o = self.exec_img_cmd('check', image_path)
+            if not s:
+                errmsg.append(o)
+
+        if len(errmsg) > 0:
+            raise ImageCheckError('Errors are found and please check log!')
+
+
+if __name__ == "__main__":
+    image_check = ImageCheck()
+    if image_check.qemu_img_check:
+        image_check.check_image()
diff --git a/client/tests/kvm/tests_base.cfg.sample b/client/tests/kvm/tests_base.cfg.sample
index 4516ed0..6ad7573 100644
--- a/client/tests/kvm/tests_base.cfg.sample
+++ b/client/tests/kvm/tests_base.cfg.sample
@@ -1042,6 +1042,9 @@ virtio|virtio_blk|e1000:
 variants:
     - @qcow2:
         image_format = qcow2
+        post_command = " python scripts/check_image.py;"
+        remove_image = no
+        post_command_timeout = 600
     - vmdk:
         only Fedora Ubuntu Windows
         only smp2
-- 
1.5.5.6


             reply	other threads:[~2010-02-24 10:30 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-24 10:30 Feng Yang [this message]
  -- strict thread matches above, loose matches on Subject: below --
2010-01-29 10:17 [PATCH] KVM Test: Add check_image script as post_command script of qcow2 variant Feng Yang
2010-02-10 16:23 ` Lucas Meneghel Rodrigues
2010-02-22  9:29   ` Feng Yang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1267007409-3379-1-git-send-email-fyang@redhat.com \
    --to=fyang@redhat.com \
    --cc=autotest@test.kernel.org \
    --cc=kvm@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.