From: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
To: David Miller <davem@davemloft.net>
Cc: "jeff@garzik.org" <jeff@garzik.org>,
"Kirsher, Jeffrey T" <jeffrey.t.kirsher@intel.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"gospo@redhat.com" <gospo@redhat.com>
Subject: Re: [net-next-2.6 PATCH] ethtool: Add n-tuple string length to drvinfo and return it
Date: Fri, 26 Feb 2010 12:08:32 -0800 [thread overview]
Message-ID: <1267214912.2224.1.camel@localhost> (raw)
In-Reply-To: <20100226.051145.01410157.davem@davemloft.net>
On Fri, 2010-02-26 at 05:11 -0800, David Miller wrote:
> From: Jeff Garzik <jeff@garzik.org>
> Date: Fri, 26 Feb 2010 08:05:19 -0500
>
> > NAK. Did you even read the patch?
>
> I did, brain doesn't work sometimes :-)
>
> > We don't increase the size of struct ethtool_drvinfo, _especially_ by
> > sticking struct members into the middle of the struct.
> >
Brain lapse. When you mentioned ABI not being locked down until 2.6.34
is dropped, I didn't think.
I'm testing your proposed change, and once I have it working, I'll give
it to Jeff K. to get pushed along with a new userspace patch.
> > What do you think 'reserved' is for???
>
> Right, I'll revert, thanks.
next prev parent reply other threads:[~2010-02-26 20:08 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-26 11:54 [net-next-2.6 PATCH] ethtool: Add n-tuple string length to drvinfo and return it Jeff Kirsher
2010-02-26 12:20 ` David Miller
2010-02-26 13:05 ` Jeff Garzik
2010-02-26 13:11 ` David Miller
2010-02-26 20:08 ` Peter P Waskiewicz Jr [this message]
2010-02-26 13:44 ` [PATCH] " Jeff Garzik
2010-02-26 13:56 ` Jeff Garzik
2010-02-26 13:59 ` Jeff Garzik
2010-02-26 23:49 ` Peter P Waskiewicz Jr
2010-02-27 6:31 ` Jeff Garzik
2010-02-27 7:25 ` Jeff Garzik
2010-02-27 20:28 ` Waskiewicz Jr, Peter P
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1267214912.2224.1.camel@localhost \
--to=peter.p.waskiewicz.jr@intel.com \
--cc=davem@davemloft.net \
--cc=gospo@redhat.com \
--cc=jeff@garzik.org \
--cc=jeffrey.t.kirsher@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.