From: Maxim Levitsky <maximlevitsky@gmail.com>
To: linux-mmc@vger.kernel.org
Cc: Vasily Khoruzhick <anarsoul@gmail.com>, linux-kernel@vger.kernel.org
Subject: [PATCH] Subject: MMC: Enable DMA on Ricoh sdhci reader by default
Date: Fri, 26 Feb 2010 23:25:11 +0200 [thread overview]
Message-ID: <1267219511-20657-1-git-send-email-maximlevitsky@gmail.com> (raw)
In-Reply-To: <20100224120038.3f0ec412.akpm@linux-foundation.org>
From: Vasily Khoruzhick <anarsoul@gmail.com>
This card reader doesn't advertise, however DMA works well.
Probably windows SDHCI driver assumes that all readers support DMA
and thus we see that bug.
Signed-off-by: Vasily Khoruzhick <anarsoul@gmail.com>
Tested-by: Maxim Levitsky <maximlevitsky@gmail.com>
---
drivers/mmc/host/sdhci-pci.c | 7 +++----
1 files changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/mmc/host/sdhci-pci.c b/drivers/mmc/host/sdhci-pci.c
index 5c3a176..12f5b09 100644
--- a/drivers/mmc/host/sdhci-pci.c
+++ b/drivers/mmc/host/sdhci-pci.c
@@ -80,9 +80,6 @@ struct sdhci_pci_chip {
static int ricoh_probe(struct sdhci_pci_chip *chip)
{
- if (chip->pdev->subsystem_vendor == PCI_VENDOR_ID_IBM)
- chip->quirks |= SDHCI_QUIRK_CLOCK_BEFORE_RESET;
-
if (chip->pdev->subsystem_vendor == PCI_VENDOR_ID_SAMSUNG ||
chip->pdev->subsystem_vendor == PCI_VENDOR_ID_SONY)
chip->quirks |= SDHCI_QUIRK_NO_CARD_NO_RESET;
@@ -92,7 +89,9 @@ static int ricoh_probe(struct sdhci_pci_chip *chip)
static const struct sdhci_pci_fixes sdhci_ricoh = {
.probe = ricoh_probe,
- .quirks = SDHCI_QUIRK_32BIT_DMA_ADDR,
+ .quirks = SDHCI_QUIRK_32BIT_DMA_ADDR |
+ SDHCI_QUIRK_FORCE_DMA |
+ SDHCI_QUIRK_CLOCK_BEFORE_RESET,
};
static const struct sdhci_pci_fixes sdhci_ene_712 = {
--
1.6.3.3
prev parent reply other threads:[~2010-02-26 21:25 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-01 9:10 [PATCH] Enable DMA for Ricoh reader on Lenovo laptops Vasily Khoruzhick
2010-02-02 16:17 ` [PATCH v2] " Vasily Khoruzhick
2010-02-13 22:38 ` Vasily Khoruzhick
2010-02-14 16:39 ` Maxim Levitsky
2010-02-14 23:06 ` Vasily Khoruzhick
2010-02-14 23:20 ` Maxim Levitsky
2010-02-15 9:49 ` Vasily Khoruzhick
2010-02-15 15:58 ` Maxim Levitsky
2010-02-15 16:20 ` Vasily Khoruzhick
2010-02-17 0:35 ` Maxim Levitsky
2010-02-20 8:49 ` Vasily Khoruzhick
2010-02-20 22:21 ` Maxim Levitsky
2010-02-24 20:00 ` Andrew Morton
2010-02-26 21:25 ` Maxim Levitsky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1267219511-20657-1-git-send-email-maximlevitsky@gmail.com \
--to=maximlevitsky@gmail.com \
--cc=anarsoul@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.