From: Ian Campbell <Ian.Campbell@citrix.com>
To: Jeremy Fitzhardinge <jeremy@goop.org>
Cc: Sheng Yang <sheng@linux.intel.com>,
Keir Fraser <Keir.Fraser@eu.citrix.com>,
Ingo Molnar <mingo@elte.hu>, Ian Pratt <Ian.Pratt@eu.citrix.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
xen-devel <xen-devel@lists.xensource.com>
Subject: Re: [PATCH 6/7] xen: Enable PV clocksource for HVM
Date: Thu, 4 Mar 2010 20:25:03 +0000 [thread overview]
Message-ID: <1267734303.20243.5.camel@localhost.localdomain> (raw)
In-Reply-To: <4B8FF0A3.9060305@goop.org>
On Thu, 2010-03-04 at 09:40 -0800, Jeremy Fitzhardinge wrote:
>
> > +
> > +static void __init init_pv_clocksource(void)
> > +{
> > + if (enable_hvm_pv(HVM_PV_CLOCK))
> > + BUG();
> >
>
> BUG is a bit severe. Will it really never, ever fail?
When running on a hypervisor without these extension, for example.
Ian.
--
Ian Campbell
My polyvinyl cowboy wallet was made in Hong Kong by Montgomery Clift!
next prev parent reply other threads:[~2010-03-04 20:25 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-04 9:36 [PATCH 0/7][v5] PV extension of HVM (Hybrid) for Xen Sheng Yang
2010-03-04 9:36 ` [PATCH 1/7] xen: add support for hvm_op Sheng Yang
2010-03-04 9:36 ` [PATCH 2/7] xen: Import cpuid.h from Xen Sheng Yang
2010-03-04 9:36 ` [PATCH 3/7] xen: Make pv drivers only work with xen_pv_domain() Sheng Yang
2010-03-04 9:36 ` [PATCH 4/7] xen/hvm: Xen PV extension of HVM initialization Sheng Yang
2010-03-04 18:24 ` Jeremy Fitzhardinge
2010-03-04 9:36 ` [PATCH 5/7] x86/xen: The entrance for PV extension of HVM Sheng Yang
2010-03-04 9:36 ` [PATCH 6/7] xen: Enable PV clocksource for HVM Sheng Yang
2010-03-04 17:40 ` Jeremy Fitzhardinge
2010-03-04 20:25 ` Ian Campbell [this message]
2010-03-05 2:54 ` Sheng Yang
2010-03-05 9:31 ` Ian Campbell
2010-03-08 7:05 ` Sheng Yang
2010-03-04 9:36 ` [PATCH 7/7] xen: Make event channel work with PV extension of HVM Sheng Yang
2010-03-04 18:24 ` Jeremy Fitzhardinge
2010-03-04 19:22 ` [Xen-devel] " Stefano Stabellini
2010-03-05 2:45 ` Sheng Yang
-- strict thread matches above, loose matches on Subject: below --
2010-03-05 6:07 [PATCH 0/7][v6] PV extension of HVM (Hybrid) for Xen Sheng Yang
2010-03-05 6:07 ` [PATCH 6/7] xen: Enable PV clocksource for HVM Sheng Yang
2010-03-08 7:18 [PATCH 0/7][v7] PV extension of HVM (Hybrid) for Xen Sheng Yang
2010-03-08 7:18 ` [PATCH 6/7] xen: Enable PV clocksource for HVM Sheng Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1267734303.20243.5.camel@localhost.localdomain \
--to=ian.campbell@citrix.com \
--cc=Ian.Pratt@eu.citrix.com \
--cc=Keir.Fraser@eu.citrix.com \
--cc=jeremy@goop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=sheng@linux.intel.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.