From: Mike Galbraith <efault@gmx.de>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [ANNOUNCE] Git 1.7.0.2
Date: Mon, 08 Mar 2010 06:55:58 +0100 [thread overview]
Message-ID: <1268027758.6298.109.camel@marge.simson.net> (raw)
In-Reply-To: <7vbpez4cr6.fsf@alter.siamese.dyndns.org>
On Sun, 2010-03-07 at 21:13 -0800, Junio C Hamano wrote:
> Mike Galbraith <efault@gmx.de> writes:
>
> > On Sun, 2010-03-07 at 14:29 -0800, Junio C Hamano wrote:
> >
> >> * "git bisect -- pathspec..." did not diagnose an error condition properly when
> >> the simplification with given pathspec made the history empty.
> >
> > Would that be what led to this somewhat less than perfect tip bisection
> > result?
>
> The bugfix was about the case where there was no change between the bad
> and good commit with respect to the given pathspec, so I suspect your case
> was irrelevant.
Oh, ok. Thanks.
> Your case probably was coming from that you originally suspected one of
> the commits that touch tools/perf was a culprit, but because that initial
> suspicion was wrong, bisection didn't find anything useful.
Hm, the successfully bisected and verified culprit was pure tools/perf.
marge:..git/linux-2.6 # git show 804b36068eccd8163ccea420c662fb5d1a21b141|grep diff
diff --git a/tools/perf/Makefile b/tools/perf/Makefile
diff --git a/tools/perf/builtin-probe.c b/tools/perf/builtin-probe.c
diff --git a/tools/perf/util/probe-finder.c b/tools/perf/util/probe-finder.c
diff --git a/tools/perf/util/probe-finder.h b/tools/perf/util/probe-finder.h
Oh well. Something went wonky.. I'll survive :)
-Mike
prev parent reply other threads:[~2010-03-08 5:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-07 22:29 [ANNOUNCE] Git 1.7.0.2 Junio C Hamano
2010-03-08 3:51 ` Mike Galbraith
2010-03-08 5:13 ` Junio C Hamano
2010-03-08 5:55 ` Mike Galbraith [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1268027758.6298.109.camel@marge.simson.net \
--to=efault@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.