From: Johannes Berg <johannes@sipsolutions.net>
To: Stanislaw Gruszka <sgruszka@redhat.com>
Cc: linux-wireless@vger.kernel.org,
Reinette Chatre <reinette.chatre@intel.com>
Subject: Re: [RFC] mac80211,iwlwifi: disabling qos queues
Date: Wed, 10 Mar 2010 15:59:57 -0800 [thread overview]
Message-ID: <1268265597.4192.3.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <20100310152024.GB2969@dhcp-lab-161.englab.brq.redhat.com>
On Wed, 2010-03-10 at 16:20 +0100, Stanislaw Gruszka wrote:
> On Tue, Mar 09, 2010 at 02:21:14PM +0100, Stanislaw Gruszka wrote:
> > Problem is that we enable QoS queues, when AP do not send us any QoS
> > parameters. I think when AP not support QoS and does not tell anything
> > about that, we should not enable QoS in H/W. I prepared a draft patch,
> > it fixes the issue. However I'm not sure if this is right approach,
> > perhaps we should find something better.
>
> I divide my fix into two patches. I'll send them in next emails.
> If no one have objections I'll post them "officially" with -stable cc.
I have objections. Or maybe not, but I don't think this makes a whole
lot of sense since the BE queue should be programmed in the "qos turned
off" way normally. That may be broken right now, but to me your patches
seem like a workaround rather than a solution which would require an
analysis of what's really going on.
johannes
next prev parent reply other threads:[~2010-03-11 6:40 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-09 13:21 [RFC] mac80211,iwlwifi: disabling qos queues Stanislaw Gruszka
2010-03-10 15:20 ` Stanislaw Gruszka
2010-03-10 23:59 ` Johannes Berg [this message]
2010-03-11 9:56 ` Stanislaw Gruszka
2010-03-11 15:06 ` Johannes Berg
2010-03-16 14:51 ` Stanislaw Gruszka
2010-03-16 21:18 ` Johannes Berg
2010-03-17 9:26 ` Stanislaw Gruszka
2010-03-17 15:51 ` Johannes Berg
2010-03-19 10:56 ` [RFC PATCH 1/2] mac80211: add interface for disabling QoS Stanislaw Gruszka
2010-03-19 10:59 ` [RFC PATCH 2/2] iwlwifi: implement " Stanislaw Gruszka
2010-03-19 14:37 ` [RFC PATCH 1/2] mac80211: add interface for " Johannes Berg
2010-03-19 15:57 ` Stanislaw Gruszka
2010-03-19 16:39 ` Johannes Berg
2010-03-10 15:21 ` [RFC PATCH 1/2] mac80211: disable_qos callback Stanislaw Gruszka
2010-03-10 20:31 ` Luis R. Rodriguez
2010-03-11 9:33 ` Stanislaw Gruszka
2010-03-17 9:19 ` Stanislaw Gruszka
2010-03-10 15:22 ` [RFC PATCH 2/2] iwlwifi: implement disable_qos Stanislaw Gruszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1268265597.4192.3.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=reinette.chatre@intel.com \
--cc=sgruszka@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.