From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755602Ab0CLEh1 (ORCPT ); Thu, 11 Mar 2010 23:37:27 -0500 Received: from mail.gmx.net ([213.165.64.20]:41678 "HELO mail.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1755194Ab0CLEhY (ORCPT ); Thu, 11 Mar 2010 23:37:24 -0500 X-Authenticated: #14349625 X-Provags-ID: V01U2FsdGVkX1/mSFwklC3muP16Rq2B14k8m1ebdz3+y6zbTwhif8 7+ORFBKjIxWG2P Subject: Re: [tip:sched/core] sched: Remove AFFINE_WAKEUPS feature From: Mike Galbraith To: Yong Zhang Cc: mingo@redhat.com, hpa@zytor.com, linux-kernel@vger.kernel.org, a.p.zijlstra@chello.nl, tglx@linutronix.de, mingo@elte.hu, linux-tip-commits@vger.kernel.org In-Reply-To: <20100312032333.GA13021@windriver.com> References: <1268301890.6785.50.camel@marge.simson.net> <20100312032333.GA13021@windriver.com> Content-Type: text/plain Date: Fri, 12 Mar 2010 05:37:19 +0100 Message-Id: <1268368639.6302.2.camel@marge.simson.net> Mime-Version: 1.0 X-Mailer: Evolution 2.24.1.1 Content-Transfer-Encoding: 7bit X-Y-GMX-Trusted: 0 X-FuHaFi: 0.51000000000000001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2010-03-12 at 11:23 +0800, Yong Zhang wrote: > On Thu, Mar 11, 2010 at 06:33:38PM +0000, tip-bot for Mike Galbraith wrote: > > Commit-ID: beac4c7e4a1cc6d57801f690e5e82fa2c9c245c8 > > Gitweb: http://git.kernel.org/tip/beac4c7e4a1cc6d57801f690e5e82fa2c9c245c8 > > Author: Mike Galbraith > > AuthorDate: Thu, 11 Mar 2010 17:17:20 +0100 > > Committer: Ingo Molnar > > CommitDate: Thu, 11 Mar 2010 18:32:53 +0100 > > > > sched: Remove AFFINE_WAKEUPS feature > > > > Disabling affine wakeups is too horrible to contemplate. Remove the feature flag. > > AFFINE_WAKEUPS is still left in sched_feature.h Oops, axe got dull. Thanks for checking. -Mike > From: Yong Zhang > Date: Fri, 12 Mar 2010 11:14:26 +0800 > Subject: [PATCH] sched: clean AFFINE_WAKEUPS feature > > complementary work to commit beac4c7e4a1cc6d57801f690e5e82fa2c9c245c8 > > Signed-off-by: Yong Zhang > --- > kernel/sched_features.h | 8 -------- > 1 files changed, 0 insertions(+), 8 deletions(-) > > diff --git a/kernel/sched_features.h b/kernel/sched_features.h > index 83c66e8..2137ac0 100644 > --- a/kernel/sched_features.h > +++ b/kernel/sched_features.h > @@ -17,14 +17,6 @@ SCHED_FEAT(START_DEBIT, 1) > SCHED_FEAT(WAKEUP_PREEMPT, 1) > > /* > - * Based on load and program behaviour, see if it makes sense to place > - * a newly woken task on the same cpu as the task that woke it -- > - * improve cache locality. Typically used with SYNC wakeups as > - * generated by pipes and the like, see also SYNC_WAKEUPS. > - */ > -SCHED_FEAT(AFFINE_WAKEUPS, 1) > - > -/* > * Prefer to schedule the task we woke last (assuming it failed > * wakeup-preemption), since its likely going to consume data we > * touched, increases cache locality.