All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wu Zhangjin <wuzhangjin@gmail.com>
To: John Kacur <jkacur@redhat.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
	rt-users <linux-rt-users@vger.kernel.org>,
	lkml <linux-kernel@vger.kernel.org>,
	"David S. Miller" <davem@davemloft.net>,
	Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>,
	Sergei Shtylyov <sshtylyov@ru.mvista.com>
Subject: Re: [PATCH] ide: Build break in ide-iops.c
Date: Fri, 12 Mar 2010 20:17:00 +0800	[thread overview]
Message-ID: <1268396220.9130.4.camel@falcon> (raw)
In-Reply-To: <1268395850-23408-2-git-send-email-jkacur@redhat.com>

On Fri, 2010-03-12 at 13:10 +0100, John Kacur wrote:
> I get the following build break due to 876c52cc046e00eaa2ffc5124dc187106ef57594
> 
> drivers/ide/ide-iops.c:29:26: error: asm/bootinfo.h: No such file or directory
> 

I think we'd better revert that commit
876c52cc046e00eaa2ffc5124dc187106ef57594 for it has introduced some arch
specific parts into the common ide source code.

And that commit doesn't influence the preempt-rt support, so, Thomas,
could you please revert it directly, thanks!

Regards,
	Wu Zhangjin

> Protect the include by #ifdef CONFIG_MIPS
> 
> Signed-off-by: John Kacur <jkacur@redhat.com>
> ---
>  drivers/ide/ide-iops.c |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/ide/ide-iops.c b/drivers/ide/ide-iops.c
> index 9dba71e..8d32dda 100644
> --- a/drivers/ide/ide-iops.c
> +++ b/drivers/ide/ide-iops.c
> @@ -26,7 +26,10 @@
>  #include <asm/irq.h>
>  #include <asm/uaccess.h>
>  #include <asm/io.h>
> +
> +#ifdef CONFIG_MIPS
>  #include <asm/bootinfo.h>
> +#endif
>  
>  void SELECT_MASK(ide_drive_t *drive, int mask)
>  {



  reply	other threads:[~2010-03-12 12:23 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-12 12:10 [PATCH] Build break in v2.6.33-rt6 John Kacur
2010-03-12 12:10 ` [PATCH] ide: Build break in ide-iops.c John Kacur
2010-03-12 12:17   ` Wu Zhangjin [this message]
2010-03-12 12:40     ` Thomas Gleixner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1268396220.9130.4.camel@falcon \
    --to=wuzhangjin@gmail.com \
    --cc=bzolnier@gmail.com \
    --cc=davem@davemloft.net \
    --cc=jkacur@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rt-users@vger.kernel.org \
    --cc=sshtylyov@ru.mvista.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.