All of lore.kernel.org
 help / color / mirror / Atom feed
From: "André Silva" <andre.beat@gmail.com>
To: gregkh@suse.de, linville@tuxdriver.com
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
	Andre Silva <andre.beat@gmail.com>
Subject: [PATCH 2/2] Staging: arlan: fixed coding style issues in arlan-proc.c
Date: Fri, 12 Mar 2010 15:28:16 +0000	[thread overview]
Message-ID: <1268407696-1649-2-git-send-email-andre.beat@gmail.com> (raw)
In-Reply-To: <1268407696-1649-1-git-send-email-andre.beat@gmail.com>

From: Andre Silva <andre.beat@gmail.com>

This is a patch to the arlan-proc.c file that fixes up multiple coding style
errors and warnings found by the checkpatch.pl.
I fixed some issues from my last patch as requested by Joe Perches.

Signed-off-by: Andre Silva <andre.beat@gmail.com>
---
 drivers/staging/arlan/arlan-proc.c |   30 ++++++++++++++++--------------
 1 files changed, 16 insertions(+), 14 deletions(-)

diff --git a/drivers/staging/arlan/arlan-proc.c b/drivers/staging/arlan/arlan-proc.c
index 62cd1d0..ee8dbab 100644
--- a/drivers/staging/arlan/arlan-proc.c
+++ b/drivers/staging/arlan/arlan-proc.c
@@ -9,21 +9,23 @@
 
 
 
-#define ARLAN_STR_SIZE 0x2ff0
-#define DEV_ARLAN_INFO 1
-#define DEV_ARLAN 1
-#define SARLG(type, var) {\
-	pos += sprintf(arlan_drive_info+pos, "%s\t=\t0x%x\n", #var,\
-		READSHMB(priva->card->var));\
-	}
+#define ARLAN_STR_SIZE	0x2ff0
+#define DEV_ARLAN_INFO	1
+#define DEV_ARLAN	1
+#define SARLG(type, var)\
+	do {\
+	pos += sprintf(arlan_drive_info+pos, "%s\t=\t0x%x\n", \
+			#var, READSHMB(priva->card->var));\
+	} while (0)
 
-#define SARLBN(type, var, nn) {\
-	pos += sprintf(arlan_drive_info+pos, "%s\t=\t0x", #var);\
-	for (i = 0; i < nn; i++)\
-		pos += sprintf(arlan_drive_info+pos, "%02x",\
-			READSHMB(priva->card->var[i]));\
+#define SARLBN(type, var, nn)\
+	do {\
+		SARLG(type, var);\
+		for (i = 0; i < nn; i++)\
+			pos += sprintf(arlan_drive_info + pos, "%02x",\
+				READSHMB(priva->card->var[i]));\
 		pos += sprintf(arlan_drive_info+pos, "\n");\
-	}
+	} while (0)
 
 #define SARLBNpln(type, var, nn) {\
 	for (i = 0; i < nn; i++)\
-- 
1.7.0.2


      reply	other threads:[~2010-03-12 15:29 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-12 15:28 [PATCH 1/2] Staging: arlan: fixed coding style issues in arlan-proc.c André Silva
2010-03-12 15:28 ` André Silva [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1268407696-1649-2-git-send-email-andre.beat@gmail.com \
    --to=andre.beat@gmail.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.