All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Valdis.Kletnieks@vt.edu
Cc: linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org
Subject: Re: Weird wireless/wpa_supplicant screw-up.
Date: Fri, 12 Mar 2010 19:09:09 -0800	[thread overview]
Message-ID: <1268449749.4880.2.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <5220.1268430568@localhost>

On Fri, 2010-03-12 at 16:49 -0500, Valdis.Kletnieks@vt.edu wrote:

> OK, getting closer ;)

No ... you're not getting closer at all ... you ignored my second email.

> in net/wireless/wext-compat.c, we have this in cfg80211_wext_giwencode()
> after I add some printk's:
> 
> printk(KERN_INFO "In giwencode idx=%d keys=%x cipher=%x\n", idx, wdev->wext.keys, wdev->wext.keys->params[idx].cipher);
>         if (!wdev->wext.keys || !wdev->wext.keys->params[idx].cipher) {
> printk(KERN_INFO "And we're going home...\n");
>                 erq->flags |= IW_ENCODE_DISABLED;
>                 erq->length = 0;
>                 return 0;
>         }
> 
> which produces
> 
> [  151.401195] In giwencode idx=0 keys=1d023600 cipher=0
> [  151.401198] And we're going home...

No ... look at _all_ that it produces.

[   98.592575] In giwencode idx=0 keys=ffff88001b304000 cipher=0
[   98.592580] And we're going home...
*****
[   98.592633] In giwencode idx=1 keys=ffff88001b304000 cipher=fac04
*****
[   98.592749] In giwencode idx=2 keys=ffff88001b304000 cipher=0
[   98.592751] And we're going home...
[   98.592803] In giwencode idx=3 keys=ffff88001b304000 cipher=0
[   98.592805] And we're going home...
[   98.592856] In giwencode idx=0 keys=ffff88001b304000 cipher=0
[   98.592859] And we're going home...

See? It reports one key which is the RX-only group key which is
absolutely correct.

> So the root cause has something to do with params[idx].cipher being unset.

Not at all.

GIWENCODE is 100% unsuitable for WPA. Just forget about "iwlist key".
And then we'd like to know what the actual problem is.

johannes


  parent reply	other threads:[~2010-03-13  3:08 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-08 22:22 Weird wireless/wpa_supplicant screw-up Valdis.Kletnieks
2010-03-12 11:14 ` Johannes Berg
2010-03-12 11:16   ` Johannes Berg
2010-03-12 21:49   ` Valdis.Kletnieks
2010-03-12 22:19     ` Pavel Roskin
2010-03-12 22:22       ` Valdis.Kletnieks
2010-03-13  3:09     ` Johannes Berg [this message]
2010-03-17  3:06       ` Valdis.Kletnieks
2010-03-17  3:22         ` Johannes Berg
2010-03-17  8:21           ` Valdis.Kletnieks
2010-03-17  9:03             ` Holger Schurig
2010-03-17 20:29               ` Valdis.Kletnieks

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1268449749.4880.2.camel@jlt3.sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=Valdis.Kletnieks@vt.edu \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.