All of lore.kernel.org
 help / color / mirror / Atom feed
From: Przemo Firszt <przemo@firszt.eu>
To: Jiri Kosina <jkosina@suse.cz>
Cc: Bastien Nocera <hadess@hadess.net>,
	linux-bluetooth <linux-bluetooth@vger.kernel.org>,
	marcel <marcel@holtmann.org>,
	Peter Hutterer <peter.hutterer@who-t.net>,
	Ping <pinglinux@gmail.com>, Peter Huewe <peterhuewe@gmx.de>
Subject: Re: [PATCH] Expose wacom pen tablet battery and ac thru power_supply class
Date: Tue, 16 Mar 2010 14:09:36 +0000	[thread overview]
Message-ID: <1268748576.4682.16.camel@pldmachine> (raw)
In-Reply-To: <alpine.LNX.2.00.1003161149100.18642@pobox.suse.cz>

Dnia 2010-03-16, wto o godzinie 11:49 +0100, Jiri Kosina pisze:
[..]
> I have applied it, thanks.
Thanks!
> One question still though ..
> 
> > +       case POWER_SUPPLY_PROP_CAPACITY:
> > +               /* show 100% battery capacity when charging */
> > +               if (power_state == 0)
> > +                       val->intval = 100;
> > +               else
> > +                       val->intval = power_state;
> > +               break;
> 
> Why is it not possible to show the actual percentage in the charging state 
> as well?
The device doesn't report capacity during charging as far as I can tell.
We could keep last reported value (bad idea IMHO), set it to 0 (even
worse) or set it to 100% - a bit misleading, but I can't see any other
option.

cheers,
Przemo

  reply	other threads:[~2010-03-16 14:09 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-28 20:39 [PATCH] Add sysfs battery & speed attributes for wacom bluetooth tablet Przemo Firszt
2010-03-02 12:02 ` Bastien Nocera
2010-03-02 12:11   ` Bastien Nocera
2010-03-09 19:12     ` [PATCH] Expose wacom pen tablet battery and ac thru power_supply class Przemo Firszt
2010-03-09 19:25       ` Przemo Firszt
2010-03-09 21:22         ` Jiri Kosina
2010-03-10 19:03           ` Przemo Firszt
2010-03-15 13:54             ` Jiri Kosina
2010-03-15 22:00               ` Przemo Firszt
2010-03-16 10:49                 ` Jiri Kosina
2010-03-16 14:09                   ` Przemo Firszt [this message]
2010-03-08 11:07 ` [PATCH] Add sysfs battery & speed attributes for wacom bluetooth tablet Jiri Kosina
2010-03-08 20:04   ` Przemo Firszt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1268748576.4682.16.camel@pldmachine \
    --to=przemo@firszt.eu \
    --cc=hadess@hadess.net \
    --cc=jkosina@suse.cz \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=marcel@holtmann.org \
    --cc=peter.hutterer@who-t.net \
    --cc=peterhuewe@gmx.de \
    --cc=pinglinux@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.