From mboxrd@z Thu Jan 1 00:00:00 1970 From: Benjamin Herrenschmidt Subject: Re: [PATCH] of: Fix comparison of "compatible" properties Date: Thu, 18 Mar 2010 17:25:45 +1100 Message-ID: <1268893545.2335.221.camel@pasglop> References: <20100318010001.6814.88310.stgit@angua> <20100317.231847.112586488.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20100317.231847.112586488.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org To: David Miller Cc: michal.simek-g5w7nrANp4BDPfheJLI6IQ@public.gmane.org, devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org List-Id: devicetree@vger.kernel.org On Wed, 2010-03-17 at 23:18 -0700, David Miller wrote: > > It's not quite right to do partial name match. Entries in a > compatible > > list are meant to be matched whole. If a device is compatible with > both > > "foo" and "foo1", then the device should have both strings in its > > "compatible" property. > > > > Signed-off-by: Benjamin Herrenschmidt > > (for patch description) > > Signed-off-by: Grant Likely > > Acked-by: David S. Miller BTW. While at it... sparc still has it's override here to do partial match (strncmp iirc). Do you rely on it ? Or do you do that only to be case insensitive and the "n" is a result of history ? Cheers, Ben