From: Liam Girdwood <lrg@slimlogic.co.uk>
To: Barry Song <21cnbao@gmail.com>
Cc: uclinux-dist-devel@blackfin.uclinux.org,
alsa-devel@alsa-project.org, broonie@opensource.wolfsonmicro.com,
Barry Song <barry.song@analog.com>
Subject: Re: [PATCH 1/4] extend ad1938 codec driver to ad193x supporting ad1936/7/8/9
Date: Thu, 18 Mar 2010 08:48:15 +0000 [thread overview]
Message-ID: <1268902095.3773.6.camel@odin> (raw)
In-Reply-To: <1268900221-6833-2-git-send-email-21cnbao@gmail.com>
On Thu, 2010-03-18 at 16:16 +0800, Barry Song wrote:
> This patch extends ad1938 codec driver to support ad1936/7/8/9,
> ad1936/7 use i2c bus, ad1938/9 use spi bus.
> The driver is splitted into three:
> ad193x.h and ad193x.c: common codec driver
> ad193x-spi.c: ad193x codec spi driver
> ad193x-i2c.c: ad193x codec i2c driver
Is the new common driver code the same as the original driver minus any
I2C/SPI changes ? It's difficult to see if anything else has been
changed.
Btw, have a look at wm8731.c. This driver supports both I2C and SPI and
is less churn than splitting out the code into three files.
Thanks
Liam
--
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk
next prev parent reply other threads:[~2010-03-18 8:48 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-18 8:16 [PATCH 0/4] extend ad1938 codec/machine driver to ad193x supporting ad1936/7/8/9 Barry Song
[not found] ` <1268900221-6833-1-git-send-email-21cnbao-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2010-03-18 8:16 ` [PATCH 1/4] extend ad1938 codec " Barry Song
[not found] ` <1268900221-6833-2-git-send-email-21cnbao-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2010-03-18 8:16 ` [PATCH 2/4] change bf5xx-ad1938 machine driver to bf5xx-ad193x machine driver Barry Song
[not found] ` <1268900221-6833-3-git-send-email-21cnbao-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2010-03-18 8:17 ` [PATCH 3/4] soc-cache: add i2c read entry for 8_8 mode Barry Song
2010-03-18 8:17 ` [PATCH 4/4] soc-cache: let reg be AND'ed by 0xff instead of data buffer " Barry Song
2010-03-18 9:00 ` Liam Girdwood
2010-03-18 11:30 ` Mark Brown
2010-03-18 8:51 ` [PATCH 3/4] soc-cache: add i2c read entry " Liam Girdwood
2010-03-18 11:29 ` Mark Brown
2010-03-18 11:22 ` [PATCH 2/4] change bf5xx-ad1938 machine driver to bf5xx-ad193x machine driver Mark Brown
2010-03-18 8:48 ` Liam Girdwood [this message]
2010-03-18 9:08 ` [PATCH 1/4] extend ad1938 codec driver to ad193x supporting ad1936/7/8/9 Barry Song
2010-03-18 11:18 ` Mark Brown
2010-03-18 15:57 ` [Uclinux-dist-devel] " Mike Frysinger
2010-03-18 16:20 ` Mark Brown
2010-03-18 17:17 ` Mike Frysinger
2010-03-18 18:05 ` Mark Brown
2010-03-18 18:08 ` Mike Frysinger
2010-03-19 3:30 ` Barry Song
2010-03-19 7:07 ` Barry Song
2010-03-19 9:03 ` Liam Girdwood
2010-03-19 12:24 ` Mark Brown
2010-03-22 5:50 ` Barry Song
2010-03-22 12:52 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1268902095.3773.6.camel@odin \
--to=lrg@slimlogic.co.uk \
--cc=21cnbao@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=barry.song@analog.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=uclinux-dist-devel@blackfin.uclinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.