From: john stultz <johnstul@us.ibm.com>
To: Richard Henderson <rth@twiddle.net>
Cc: lkml <linux-kernel@vger.kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Ivan Kokshaysky <ink@jurassic.park.msu.ru>,
Matt Turner <mattst88@gmail.com>
Subject: Re: [RFC][PATCH] Convert alpha to use clocksource
Date: Thu, 18 Mar 2010 10:55:23 -0700 [thread overview]
Message-ID: <1268934923.1855.8.camel@work-vm> (raw)
In-Reply-To: <4BA23974.5030503@twiddle.net>
On Thu, 2010-03-18 at 07:32 -0700, Richard Henderson wrote:
> On 03/17/2010 07:01 PM, John Stultz wrote:
> > Alpha has a tsc like rpcc counter that it uses to manage time.
> > This can be converted to an actual clocksource instead of utilizing
> > the arch_gettimeoffset method that is really only there for legacy
> > systems with no continuous counter.
>
> With 8 seconds or less between roll-overs, do you actually consider
> this a continuous counter? I don't. I suggest this be left alone.
The timekeeping code handles this (although the shift value I picked may
need some adjustment - what is the expected counter freq range on
alpha?). The ACPI PM counter which is very common on x86 is only 24 bits
and rolls over in ~5 seconds. It works fine.
However, I'm not maintaining the arch, and this patch isn't limiting the
timekeeping core, so the call is really yours. I sent this out on a whim
since it looked easy to do.
However, while this change is totally optional, I suspect my suggestion
about moving to the clockevents code is going to rise in importance. The
triplicate timer code paths of non-converted, converted periodic and
converted one-shot is difficult to follow.
I'll try to find a good example of an easy conversion case (PIT on x86
is not it) and send it your way.
thanks
-john
next prev parent reply other threads:[~2010-03-18 17:55 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-18 2:01 [RFC][PATCH] Convert alpha to use clocksource John Stultz
2010-03-18 14:32 ` Richard Henderson
2010-03-18 17:55 ` john stultz [this message]
2010-03-18 21:40 ` Ivan Kokshaysky
2010-03-18 22:19 ` john stultz
2010-03-19 10:07 ` Ivan Kokshaysky
2010-03-19 16:47 ` Matt Turner
2010-03-19 17:13 ` Richard Henderson
2010-03-22 11:17 ` Johannes Weiner
2010-03-22 14:22 ` Thomas Gleixner
2010-03-22 16:41 ` Johannes Weiner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1268934923.1855.8.camel@work-vm \
--to=johnstul@us.ibm.com \
--cc=ink@jurassic.park.msu.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=mattst88@gmail.com \
--cc=rth@twiddle.net \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.