From: Brian Gerst <brgerst@gmail.com>
To: hpa@zytor.com
Cc: x86@kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 2/5] x86-32: Remove die_if_kernel()
Date: Thu, 18 Mar 2010 14:20:50 -0400 [thread overview]
Message-ID: <1268936453-3727-3-git-send-email-brgerst@gmail.com> (raw)
In-Reply-To: <1268936453-3727-1-git-send-email-brgerst@gmail.com>
Merge die_if_kernel() into do_cache_flush_error().
Signed-off-by: Brian Gerst <brgerst@gmail.com>
---
arch/x86/kernel/traps.c | 12 ++----------
1 files changed, 2 insertions(+), 10 deletions(-)
diff --git a/arch/x86/kernel/traps.c b/arch/x86/kernel/traps.c
index 45b9cb0..cea343e 100644
--- a/arch/x86/kernel/traps.c
+++ b/arch/x86/kernel/traps.c
@@ -108,15 +108,6 @@ static inline void preempt_conditional_cli(struct pt_regs *regs)
dec_preempt_count();
}
-#ifdef CONFIG_X86_32
-static inline void
-die_if_kernel(const char *str, struct pt_regs *regs, long err)
-{
- if (!user_mode_vm(regs))
- die(str, regs, err);
-}
-#endif
-
static void __kprobes
do_trap(int trapnr, int signr, char *str, struct pt_regs *regs,
long error_code, siginfo_t *info)
@@ -273,7 +264,8 @@ do_cache_flush_error(struct pt_regs *regs, long error_code)
}
current->thread.trap_no = 19;
current->thread.error_code = error_code;
- die_if_kernel("cache flush denied", regs, error_code);
+ if (!user_mode(regs))
+ die("cache flush denied", regs, error_code);
force_sig(SIGSEGV, current);
}
#endif
--
1.6.6.1
next prev parent reply other threads:[~2010-03-18 18:21 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-18 18:20 [PATCH 0/5] x86: Merge fpu and simd exception handlers Brian Gerst
2010-03-18 18:20 ` [PATCH 1/5] x86-32: Split cache flush handler from simd handler Brian Gerst
2010-03-19 22:33 ` H. Peter Anvin
2010-03-20 4:08 ` Brian Gerst
2010-03-20 4:55 ` H. Peter Anvin
2010-03-20 18:53 ` H. Peter Anvin
2010-03-18 18:20 ` Brian Gerst [this message]
2010-03-18 18:20 ` [PATCH 3/5] x86: Merge simd_math_error() into math_error() Brian Gerst
2010-03-18 18:20 ` [PATCH 4/5] x86: Merge kernel_math_error() " Brian Gerst
2010-03-18 18:20 ` [PATCH 5/5] x86-32: Don't set ignore_fpu_irq in simd exception Brian Gerst
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1268936453-3727-3-git-send-email-brgerst@gmail.com \
--to=brgerst@gmail.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.