From: Marcel Holtmann <marcel@holtmann.org>
To: ofono@ofono.org
Subject: Re: [PATCH 0/6] PPP Patches v3
Date: Mon, 22 Mar 2010 19:22:00 -0700 [thread overview]
Message-ID: <1269310920.4851.32.camel@localhost.localdomain> (raw)
In-Reply-To: <1269304355.4851.24.camel@localhost.localdomain>
[-- Attachment #1: Type: text/plain, Size: 908 bytes --]
Hi Kristen,
> > Changes since v2 - corrected whitespace.
>
> all the patches have been applied.
>
> So form now on please send smaller patches as soon as you have them
> ready and tested. If you need comments or have questions, you can use
> the mailing list as well.
some additional comments from my side.
If you have variables that are only valid inside the scope of a
statement, then I prefer if you only declare them there. This makes the
code a bit simpler to read. Check the patch I just pushed to give you an
example.
Also please find access to a 32-bit system if you are running 64-bit or
vice versa. Our build system is strict and will turn turn all casting
mistakes in an error.
Please be present on #ofono IRC as much as possible so people can report
such things. Remember that your code is now part of the tree and it can
break the build.
Regards
Marcel
next prev parent reply other threads:[~2010-03-23 2:22 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-23 0:05 [PATCH 0/6] PPP Patches v3 Kristen Carlson Accardi
2010-03-23 0:05 ` [PATCH 1/6] Basic PPP protocol support Kristen Carlson Accardi
2010-03-23 0:05 ` [PATCH 2/6] Generic PPP control " Kristen Carlson Accardi
2010-03-23 0:05 ` [PATCH 3/6] PPP LCP support Kristen Carlson Accardi
2010-03-23 0:05 ` [PATCH 4/6] CHAP with MD5 authentication support Kristen Carlson Accardi
2010-03-23 0:06 ` [PATCH 5/6] IP support for PPP Kristen Carlson Accardi
2010-03-23 0:06 ` [PATCH 6/6] Add PPP option to gsmdial Kristen Carlson Accardi
2010-03-23 5:30 ` Gustavo F. Padovan
2010-03-23 6:30 ` Marcel Holtmann
2010-03-23 0:32 ` [PATCH 0/6] PPP Patches v3 Marcel Holtmann
2010-03-23 2:22 ` Marcel Holtmann [this message]
2010-03-23 3:22 ` Kristen Carlson Accardi
2010-03-23 3:47 ` Marcel Holtmann
2010-03-23 4:07 ` Kristen Carlson Accardi
2010-03-23 4:51 ` Marcel Holtmann
2010-03-23 6:14 ` Kristen Carlson Accardi
2010-03-23 6:45 ` Marcel Holtmann
2010-03-23 17:16 ` Kristen Carlson Accardi
2010-03-23 17:34 ` Kristen Carlson Accardi
2010-03-23 17:56 ` Marcel Holtmann
2010-03-23 18:26 ` Kristen Carlson Accardi
2010-03-23 18:37 ` Denis Kenzior
2010-03-23 19:07 ` Marcel Holtmann
2010-03-23 3:56 ` Kristen Carlson Accardi
2010-03-23 12:34 ` =?unknown-8bit?q?R=C3=A9mi?= Denis-Courmont
2010-03-23 12:49 ` Marcel Holtmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1269310920.4851.32.camel@localhost.localdomain \
--to=marcel@holtmann.org \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.