From: john stultz <johnstul@us.ibm.com>
To: Russell King <rmk+lkml@arm.linux.org.uk>
Cc: lkml <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] arm: convert arm to arch_gettimeoffset()
Date: Tue, 23 Mar 2010 17:49:02 -0700 [thread overview]
Message-ID: <1269391742.2347.33.camel@localhost> (raw)
In-Reply-To: <20100324003409.GB24827@flint.arm.linux.org.uk>
On Wed, 2010-03-24 at 00:34 +0000, Russell King wrote:
> On Tue, Mar 23, 2010 at 04:05:21PM -0700, John Stultz wrote:
> > Convert arm to use GENERIC_TIME via the arch_getoffset() infrastructure,
> > reducing the amount of arch specific code we need to maintain.
> >
> > The arm architecture is the last arch that need to be converted.
>
> Much easier to merge, thanks.
>
> While looking for a machine to build-test this, I noticed that the IOP/IXP
> platforms have ARCH_USES_GETTIMEOFFSET - yet they select PLAT_IOP which
> in turn selects GENERIC_TIME etc.
>
> I think ARCH_IOP13XX, ARCH_IOP32X and ARCH_IOP33X shouldn't select
> ARCH_USES_GETTIMEOFFSET - do you agree?
Oh, sorry! I didn't notice the PLAT_IOP was a superset of the IOP
arches, thanks for catching that!
The generalized rule is: if they have clocksources, then you're right,
ARCH_USES_GETTIMEOFFSET should not be used then (since it disables any
non-jiffies clocksources from being used).
Do you need a new respin removing those lines, or are you comfortable
modifying the patch already sent?
Thanks again for the review and help here!
-john
prev parent reply other threads:[~2010-03-24 0:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-23 23:05 [PATCH] arm: convert arm to arch_gettimeoffset() John Stultz
2010-03-23 23:05 ` [PATCH] arm: Remove GENERIC_TIME cruft John Stultz
2010-03-24 0:34 ` [PATCH] arm: convert arm to arch_gettimeoffset() Russell King
2010-03-24 0:49 ` john stultz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1269391742.2347.33.camel@localhost \
--to=johnstul@us.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rmk+lkml@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.