From: Michael Ellerman <michael@ellerman.id.au>
To: Ingo Molnar <mingo@elte.hu>
Cc: Yinghai Lu <yinghai@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
"H. Peter Anvin" <hpa@zytor.com>,
Andrew Morton <akpm@linux-foundation.org>,
David Miller <davem@davemloft.net>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH -v4 00/08] use lmb with x86
Date: Wed, 24 Mar 2010 22:41:08 +1100 [thread overview]
Message-ID: <1269430868.2500.14.camel@concordia> (raw)
In-Reply-To: <20100324104844.GA896@elte.hu>
[-- Attachment #1: Type: text/plain, Size: 890 bytes --]
On Wed, 2010-03-24 at 11:48 +0100, Ingo Molnar wrote:
> * Yinghai Lu <yinghai@kernel.org> wrote:
>
> > new early_res is lmb extension. and it could be used to replace bootmem.
>
> Why not do what we suggested: extend lmb.c to also offer the
> early_res-equivalent functionality, and remove kernel/early_res.c and move
> lib/lmb.c to mm/lmb.c?
>
> We dont want two facilities (early_res and lmb) really ...
Exactly.
This series seems to leave us with kernel/early_res.c (which should
never have moved out of arch/x86 AFAICS) - as well as using some of
lmb.c.
It doesn't compile on powerpc, because early_res.c is looking for
find_fw_memmap_area() which is still under arch/x86.
And sprinkling CONFIG_NO_BOOTMEM everywhere is getting a bit gross. I
notice that's already happened to mm/(bootmem|page_alloc).c but
propagating it further is not nice.
cheers
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 197 bytes --]
next prev parent reply other threads:[~2010-03-24 11:41 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-24 10:37 [PATCH -v4 00/08] use lmb with x86 Yinghai Lu
2010-03-24 10:37 ` [PATCH 1/8] x86: do not free zero sized per cpu areas Yinghai Lu
2010-03-25 22:29 ` Joel Becker
2010-03-24 10:37 ` [PATCH 2/8] x86: add find_e820_area_node Yinghai Lu
2010-03-24 10:37 ` [PATCH 3/8] x86: add sanitize_e820_map Yinghai Lu
2010-03-24 10:37 ` [PATCH 4/8] lmb: seperate region array from lmb_region struct Yinghai Lu
2010-03-24 10:37 ` [PATCH 5/8] x86: use lmb to replace early_res Yinghai Lu
2010-03-24 10:37 ` [PATCH 6/8] x86: remove find_e820_area Yinghai Lu
2010-03-24 10:37 ` [PATCH 7/8] early_res: prepare for other platform to use it Yinghai Lu
2010-03-24 10:37 ` [PATCH 8/8] powerpc : use early_res/nobootmem Yinghai Lu
2010-03-24 10:48 ` [PATCH -v4 00/08] use lmb with x86 Ingo Molnar
2010-03-24 11:41 ` Michael Ellerman [this message]
2010-03-24 18:18 ` Yinghai Lu
2010-03-24 18:31 ` Yinghai Lu
-- strict thread matches above, loose matches on Subject: below --
2010-03-24 10:34 Yinghai Lu
2010-03-24 10:34 ` Yinghai Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1269430868.2500.14.camel@concordia \
--to=michael@ellerman.id.au \
--cc=akpm@linux-foundation.org \
--cc=benh@kernel.crashing.org \
--cc=davem@davemloft.net \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.