From: Pavel Roskin <proski@gnu.org>
To: Valentin Longchamp <valentin.longchamp@epfl.ch>
Cc: chunkeey@web.de, linux-wireless@vger.kernel.org
Subject: Re: [PATCH] setup correct int pipe type in ar9170_usb_exec_cmd
Date: Fri, 26 Mar 2010 16:57:03 -0400 [thread overview]
Message-ID: <1269637023.8534.17.camel@mj> (raw)
In-Reply-To: <1269600273-7974-1-git-send-email-valentin.longchamp@epfl.ch>
On Fri, 2010-03-26 at 11:44 +0100, Valentin Longchamp wrote:
> An int urb is constructed but we fill it in with a bulk pipe type.
>
> Commit f661c6f8c67bd55e93348f160d590ff9edf08904 implemented a pipe type
> check when CONFIG_USB_DEBUG is enabled. The check failed for all the ar9170
> usb transfers and the driver could not configure the wifi dongle.
>
> This went unnoticed until now because most people don't have
> CONFIG_USB_DEBUG enabled.
Actually, if the code was broken and nobody noticed, do we need it at
all? ar9170_usb_tx_urb_complete() is an empty function.
Suppose we need it, then maybe we could put some debug code there? I
think that function has a poor name, it should be something with "cmd",
like ar9170_usb_tx_urb_complete_cmd().
By the way, I think such fixes belong to stable.
--
Regards,
Pavel Roskin
next prev parent reply other threads:[~2010-03-26 20:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-26 10:44 [PATCH] setup correct int pipe type in ar9170_usb_exec_cmd Valentin Longchamp
2010-03-26 20:57 ` Pavel Roskin [this message]
2010-03-27 12:22 ` Christian Lamparter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1269637023.8534.17.camel@mj \
--to=proski@gnu.org \
--cc=chunkeey@web.de \
--cc=linux-wireless@vger.kernel.org \
--cc=valentin.longchamp@epfl.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.