Re: [PATCH 1/7] arm: msm: smd: checkpatch clean up of smd/proc_comm

[Daniel Walker <dwalker@codeaurora.org>]

On Sat, 2010-03-27 at 07:14 +0100, Pavel Machek wrote:
> On Fri 2010-03-26 16:55:19, Daniel Walker wrote:
> > This cleans up codeing style. There are no run time changes.
> > 
> > Signed-off-by: Daniel Walker <dwalker@codeaurora.org>
> 
> ACK.
> 
> > @@ -904,9 +902,9 @@ static irqreturn_t smsm_irq_handler(int irq, void *data)
> >  
> >  	if (msm_smd_debug_mask & MSM_SMSM_DEBUG)
> >  		pr_info("<SM %08x %08x>\n", apps, modm);

> > -	if (modm & SMSM_RESET) {
> > +	if (modm & SMSM_RESET)
> >  		handle_modem_crash();
> > -	}
> > +
> >  	do_smd_probe();
> >  
> >  	spin_unlock_irqrestore(&smem_lock, flags);
> 
> Even through I do not think this is an improvement. Especially
> considering the if() immediately before that.

I could add a space in there, might make it more clear.

Daniel