All of lore.kernel.org
 help / color / mirror / Atom feed
From: Olimpiu Pascariu <olimpiu.pascariu@gmail.com>
To: apw@canonical.com, akpm@linux-foundation.org, dwalker@fifo99.com,
	joe@perches.com
Cc: linux-kernel@vger.kernel.org
Subject: Checkpatch.pl false positive? "ERROR: return is not a function, parentheses are not required"
Date: Sun, 28 Mar 2010 22:28:13 +0300	[thread overview]
Message-ID: <1269804493.7079.14.camel@tuxtm-linux> (raw)

Hi,

I've used checkpatch.pl to verify drivers/staging/dt3155/dt3155_isr.c,
in order to provide a patch which fixes the errors and warnings found by
checkpatch.
The script returns the following error:
ERROR: return is not a function, parentheses are not required
#155: FILE: staging/dt3155/dt3155_isr.c:155:
+  return (dt3155_fbuffer[m]->ready_head -

The original code is:

  return (dt3155_fbuffer[m]->ready_head -
           dt3155_fbuffer[m]->ready_len +
           dt3155_fbuffer[m]->nbuffers)%
          (dt3155_fbuffer[m]->nbuffers);

I've deleted the the first open parenthesis and the last close
parenthesis, and now the code looks like this:

  return (dt3155_fbuffer[m]->ready_head -
           dt3155_fbuffer[m]->ready_len +
           dt3155_fbuffer[m]->nbuffers)%
          (dt3155_fbuffer[m]->nbuffers);

IMHO the code is correct, though an auxiliary variable could be used to
avoid this error returned by checkpatch.pl. 

Regards,
Olimpiu Pascariu





             reply	other threads:[~2010-03-28 19:28 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-28 19:28 Olimpiu Pascariu [this message]
2010-03-28 20:09 ` Checkpatch.pl false positive? "ERROR: return is not a function, parentheses are not required" Alexey Dobriyan
2010-03-28 19:59   ` Joe Perches
2010-03-28 20:56     ` Olimpiu Pascariu
2010-09-02 13:44 ` Andy Whitcroft

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1269804493.7079.14.camel@tuxtm-linux \
    --to=olimpiu.pascariu@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=apw@canonical.com \
    --cc=dwalker@fifo99.com \
    --cc=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.