From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Julia Lawall <julia@diku.dk>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: question about drivers/macintosh/windfarm_pm91.c
Date: Mon, 29 Mar 2010 08:08:59 +1100 [thread overview]
Message-ID: <1269810539.8599.330.camel@pasglop> (raw)
In-Reply-To: <Pine.LNX.4.64.1003281746570.29824@ask.diku.dk>
On Sun, 2010-03-28 at 17:48 +0200, Julia Lawall wrote:
> The function wf_smu_remove in the file drivers/macintosh/windfarm_pm91.c
> ends with the following code:
>
> if (wf_smu_slots_fans)
> kfree(wf_smu_cpu_fans);
> if (wf_smu_drive_fans)
> kfree(wf_smu_cpu_fans);
> if (wf_smu_cpu_fans)
> kfree(wf_smu_cpu_fans);
>
> This looks quite strange. Is it supposed to be if (x) kfree(x); in each
> case?
Definitely a typo. In fact, the if () aren't even necessary. Patch
welcome :-)
Cheers,
Ben.
next prev parent reply other threads:[~2010-03-28 21:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-28 15:48 question about drivers/macintosh/windfarm_pm91.c Julia Lawall
2010-03-28 21:08 ` Benjamin Herrenschmidt [this message]
2010-03-28 21:56 ` Julia Lawall
2010-03-28 23:07 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1269810539.8599.330.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=julia@diku.dk \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.