From: Peter Zijlstra <peterz@infradead.org>
To: paulmck@linux.vnet.ibm.com
Cc: linux-kernel@vger.kernel.org, mingo@elte.hu,
laijs@cn.fujitsu.com, dipankar@in.ibm.com,
akpm@linux-foundation.org, mathieu.desnoyers@polymtl.ca,
josh@joshtriplett.org, dvhltc@us.ibm.com, niv@us.ibm.com,
tglx@linutronix.de, rostedt@goodmis.org, Valdis.Kletnieks@vt.edu,
dhowells@redhat.com, eric.dumazet@gmail.com, abogani@texware.it
Subject: Re: [PATCH tip/core/urgent] rcu: protect fork-time cgroup access
Date: Mon, 29 Mar 2010 23:42:55 +0200 [thread overview]
Message-ID: <1269898975.12097.380.camel@laptop> (raw)
In-Reply-To: <20100329213405.GA18143@linux.vnet.ibm.com>
On Mon, 2010-03-29 at 14:34 -0700, Paul E. McKenney wrote:
> And it appears that my patch is at best insufficient:
> http://paste.ubuntu.com/406189/
>
> Left to myself, I would wrap copy_process() with rcu_read_lock(),
> but I would rather hear your thoughts before doing too much more
> semi-random hacking. ;-)
Well, I don't think you can get away with that, copy_process() wants to
sleep on quite a few places ;-) Also, locks should be taken at the
smallest possible scope, unless we want to go back to BKL style
locking :-)
As to that freezer splat, you'd have to chase down the cgroup folks, I'm
fully ignorant on that.
For the set_task_rq() one, I'm afraid someone (which again I'm afraid
will be me) will have to look into how the task_group muck ties into the
cgroup muck as I think the original authors of that ran off :/
next prev parent reply other threads:[~2010-03-29 21:43 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-29 21:15 [PATCH tip/core/urgent] rcu: protect fork-time cgroup access Paul E. McKenney
2010-03-29 21:19 ` Peter Zijlstra
2010-03-29 21:26 ` Peter Zijlstra
2010-03-29 22:24 ` Paul E. McKenney
2010-03-29 21:29 ` Paul E. McKenney
2010-03-29 21:34 ` Paul E. McKenney
2010-03-29 21:42 ` Peter Zijlstra [this message]
2010-03-29 21:51 ` Paul E. McKenney
2010-03-29 22:43 ` Paul Menage
2010-03-29 23:05 ` Paul E. McKenney
2010-03-30 18:57 ` Paul Menage
2010-03-30 8:50 ` Peter Zijlstra
2010-03-30 17:28 ` Paul E. McKenney
-- strict thread matches above, loose matches on Subject: below --
2010-03-30 9:32 Matt Helsley
2010-03-30 9:32 Matt Helsley
[not found] ` <20100330093204.GP3345-52DBMbEzqgQ/wnmkkaCWp/UQ3DHhIser@public.gmane.org>
2010-03-30 17:26 ` Paul E. McKenney
2010-03-30 17:26 ` Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1269898975.12097.380.camel@laptop \
--to=peterz@infradead.org \
--cc=Valdis.Kletnieks@vt.edu \
--cc=abogani@texware.it \
--cc=akpm@linux-foundation.org \
--cc=dhowells@redhat.com \
--cc=dipankar@in.ibm.com \
--cc=dvhltc@us.ibm.com \
--cc=eric.dumazet@gmail.com \
--cc=josh@joshtriplett.org \
--cc=laijs@cn.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@polymtl.ca \
--cc=mingo@elte.hu \
--cc=niv@us.ibm.com \
--cc=paulmck@linux.vnet.ibm.com \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.