From: Johan Jonker <jbx6244@gmail.com>
To: dario.binacchi@amarulasolutions.com,
michael@amarulasolutions.com, sjg@chromium.org,
philipp.tomsich@vrull.eu, kever.yang@rock-chips.com
Cc: u-boot@lists.denx.de, yifeng.zhao@rock-chips.com
Subject: [PATCH v6 14/22] spi: spi-aspeed-smc: use devfdt_get_addr_index_ptr
Date: Fri, 3 Mar 2023 01:15:26 +0100 [thread overview]
Message-ID: <126b092f-1739-6cea-97ef-abbdaa28a628@gmail.com> (raw)
In-Reply-To: <7256f237-4b7b-f7d7-834f-f7c3fb8984d7@gmail.com>
The fdt_addr_t and phys_addr_t size have been decoupled.
A 32bit CPU can expect 64-bit data from the device tree parser,
so use devfdt_get_addr_index_ptr and devfdt_get_addr_size_index_ptr
function in the spi-aspeed-smc.c file. Also fix dev_dbg to be able
to handle both sizes.
Signed-off-by: Johan Jonker <jbx6244@gmail.com>
Reviewed-by: Michael Trimarchi <michael@amarulasolutions.com>
---
Changed V6:
use -EINVAL on return
---
drivers/spi/spi-aspeed-smc.c | 17 ++++++++---------
1 file changed, 8 insertions(+), 9 deletions(-)
diff --git a/drivers/spi/spi-aspeed-smc.c b/drivers/spi/spi-aspeed-smc.c
index 4b6ea9f8..39620310 100644
--- a/drivers/spi/spi-aspeed-smc.c
+++ b/drivers/spi/spi-aspeed-smc.c
@@ -1125,17 +1125,16 @@ static int apseed_spi_of_to_plat(struct udevice *bus)
int ret;
struct clk hclk;
- priv->regs = (void __iomem *)devfdt_get_addr_index(bus, 0);
- if ((u32)priv->regs == FDT_ADDR_T_NONE) {
+ priv->regs = devfdt_get_addr_index_ptr(bus, 0);
+ if (!priv->regs) {
dev_err(bus, "wrong ctrl base\n");
- return -ENODEV;
+ return -EINVAL;
}
- plat->ahb_base =
- (void __iomem *)devfdt_get_addr_size_index(bus, 1, &plat->ahb_sz);
- if ((u32)plat->ahb_base == FDT_ADDR_T_NONE) {
+ plat->ahb_base = devfdt_get_addr_size_index_ptr(bus, 1, &plat->ahb_sz);
+ if (!plat->ahb_base) {
dev_err(bus, "wrong AHB base\n");
- return -ENODEV;
+ return -EINVAL;
}
plat->max_cs = dev_read_u32_default(bus, "num-cs", ASPEED_SPI_MAX_CS);
@@ -1151,8 +1150,8 @@ static int apseed_spi_of_to_plat(struct udevice *bus)
plat->hclk_rate = clk_get_rate(&hclk);
clk_free(&hclk);
- dev_dbg(bus, "ctrl_base = 0x%x, ahb_base = 0x%p, size = 0x%lx\n",
- (u32)priv->regs, plat->ahb_base, plat->ahb_sz);
+ dev_dbg(bus, "ctrl_base = 0x%x, ahb_base = 0x%p, size = 0x%llx\n",
+ (u32)priv->regs, plat->ahb_base, (fdt64_t)plat->ahb_sz);
dev_dbg(bus, "hclk = %dMHz, max_cs = %d\n",
plat->hclk_rate / 1000000, plat->max_cs);
--
2.20.1
next prev parent reply other threads:[~2023-03-03 0:15 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-03 0:08 [PATCH v6 00/22] Fixes for Rockchip NFC driver part 1 Johan Jonker
2023-03-03 0:12 ` [PATCH v6 01/22] mtd: nand: raw: rockchip_nfc: use dev_read_addr_ptr Johan Jonker
2023-03-03 0:12 ` [PATCH v6 02/22] mtd: nand: raw: rockchip_nfc: remove the compatible string "rockchip,rk3308-nfc" Johan Jonker
2023-03-03 0:12 ` [PATCH v6 03/22] mtd: nand: raw: rockchip_nfc: add layout structure Johan Jonker
2023-03-03 0:12 ` [PATCH v6 04/22] mtd: nand: raw: rockchip_nfc: add flash_node to chip structure Johan Jonker
2023-03-03 0:13 ` [PATCH v6 05/22] mtd: nand: raw: rockchip_nfc: fix oobfree offset and description Johan Jonker
2023-03-03 0:13 ` [PATCH v6 06/22] mtd: nand: add support for the Sandisk SDTNQGAMA chip Johan Jonker
2023-03-09 7:22 ` Michael Nazzareno Trimarchi
2023-03-03 0:13 ` [PATCH v6 07/22] rockchip: adc: rockchip-saradc: use dev_read_addr_ptr Johan Jonker
2023-03-03 0:13 ` [PATCH v6 08/22] rockchip: timer: dw-apb-timer: use reg variable with phys_addr_t size Johan Jonker
2023-03-03 0:14 ` [PATCH v6 09/22] rockchip: pwm: rk_pwm: " Johan Jonker
2023-03-03 0:14 ` [PATCH v6 10/22] include: dm: ofnode: fix headers Johan Jonker
2023-03-03 0:14 ` [PATCH v6 11/22] core: remap: convert regmap_init_mem_plat() input to phys_addr_t Johan Jonker
2023-03-08 8:39 ` Johan Jonker
2023-03-08 17:16 ` Simon Glass
2023-03-03 0:14 ` [PATCH v6 12/22] core: fdtaddr: add devfdt_get_addr_size_index_ptr function Johan Jonker
2023-03-06 17:53 ` Simon Glass
2023-03-06 20:55 ` Johan Jonker
2023-03-11 1:37 ` Simon Glass
2023-03-03 0:15 ` [PATCH v6 13/22] core: read: add dev_read_addr_index_ptr function Johan Jonker
2023-03-06 18:20 ` Simon Glass
2023-03-03 0:15 ` Johan Jonker [this message]
2023-03-03 0:15 ` [PATCH v6 15/22] drivers: use dev_read_addr_index_ptr when cast to pointer Johan Jonker
2023-03-06 18:20 ` Simon Glass
2023-03-06 20:32 ` Johan Jonker
2023-03-11 1:37 ` Simon Glass
2023-03-11 19:17 ` Simon Glass
2023-03-03 0:16 ` [PATCH v6 16/22] drivers: use dev_read_addr_ptr " Johan Jonker
2023-03-03 0:16 ` [PATCH v6 17/22] drivers: use devfdt_get_addr_size_index_ptr " Johan Jonker
2023-03-06 17:53 ` Simon Glass
2023-03-03 0:16 ` [PATCH v6 18/22] drivers: use devfdt_get_addr_index_ptr " Johan Jonker
2023-03-03 0:16 ` [PATCH v6 19/22] drivers: use devfdt_get_addr_ptr " Johan Jonker
2023-03-03 0:17 ` [PATCH v6 20/22] drivers: fix debug string with fdt_addr_t input Johan Jonker
2023-03-03 0:17 ` [PATCH v6 21/22] arm: stm32mp: spl: fix function " Johan Jonker
2023-03-03 0:17 ` [PATCH v6 22/22] include: fdtdec: decouple fdt_addr_t and phys_addr_t size Johan Jonker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=126b092f-1739-6cea-97ef-abbdaa28a628@gmail.com \
--to=jbx6244@gmail.com \
--cc=dario.binacchi@amarulasolutions.com \
--cc=kever.yang@rock-chips.com \
--cc=michael@amarulasolutions.com \
--cc=philipp.tomsich@vrull.eu \
--cc=sjg@chromium.org \
--cc=u-boot@lists.denx.de \
--cc=yifeng.zhao@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.