From: jamal <hadi@cyberus.ca>
To: "Timo Teräs" <timo.teras@iki.fi>
Cc: Herbert Xu <herbert@gondor.apana.org.au>,
"David S. Miller" <davem@davemloft.net>,
Patrick McHardy <kaber@trash.net>,
netdev@vger.kernel.org
Subject: Re: [RFC] SPD basic actions per netdev
Date: Thu, 01 Apr 2010 08:00:46 -0400 [thread overview]
Message-ID: <1270123246.26743.177.camel@bigi> (raw)
In-Reply-To: <4BB487CA.3020603@iki.fi>
On Thu, 2010-04-01 at 14:47 +0300, Timo Teräs wrote:
>
> The thing is that currently FWD 'dev blah' matches the interface
> to which the packet is being forwarded to. Someone might be using
> this feature already.
So this is the part i am missing i think. If i look at:
int ip_forward(struct sk_buff *skb)
{
.....
if (!xfrm4_policy_check(NULL, XFRM_POLICY_FWD, skb))
goto drop;
....
........later forwarding happens here ...
if (!xfrm4_route_forward(skb))
goto drop;
...
}
On entry we have a legit skb->skb_iif.
The validity check is before forwarding decision (where the interface
the packet is being forwarded to is recognized).
> Your patch changes semantics on how FWD policies are matched.
I agree if what you say earlier is true.
cheers,
jamal
next prev parent reply other threads:[~2010-04-01 12:00 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-31 16:37 [RFC] SPD basic actions per netdev jamal
2010-03-31 22:58 ` jamal
2010-04-01 0:33 ` Herbert Xu
2010-04-01 2:35 ` jamal
2010-04-01 2:52 ` Herbert Xu
2010-04-01 4:52 ` Timo Teräs
2010-04-01 6:01 ` Herbert Xu
2010-04-01 6:20 ` Timo Teräs
2010-04-01 6:28 ` Herbert Xu
2010-04-01 6:32 ` Timo Teräs
2010-04-01 6:39 ` Herbert Xu
2010-04-01 11:29 ` jamal
2010-04-01 11:47 ` Timo Teräs
2010-04-01 12:00 ` jamal [this message]
2010-04-01 12:10 ` Timo Teräs
2010-04-01 12:34 ` jamal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1270123246.26743.177.camel@bigi \
--to=hadi@cyberus.ca \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
--cc=timo.teras@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.