From: Johannes Berg <johannes@sipsolutions.net>
To: Teemu Paasikivi <ext-teemu.3.paasikivi@nokia.com>
Cc: linville@tuxdriver.com, linux-wireless@vger.kernel.org
Subject: Re: [PATCH] mac80211: check whether scan is in progress before queueing scan_work
Date: Tue, 06 Apr 2010 11:08:00 +0200 [thread overview]
Message-ID: <1270544880.3929.4.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <1270544765.3929.2.camel@jlt3.sipsolutions.net>
On Tue, 2010-04-06 at 11:06 +0200, Johannes Berg wrote:
> > - if (list_empty(&local->work_list) && local->scan_req)
> > + mutex_lock(&local->scan_mtx);
> > +
> > + if (list_empty(&local->work_list) && local->scan_req &&
> > + !local->scanning)
> > ieee80211_queue_delayed_work(&local->hw,
> > &local->scan_work,
> > round_jiffies_relative(0));
> >
> > + mutex_unlock(&local->scan_mtx);
> > +
> > mutex_unlock(&local->work_mtx);
>
> That really doesn't look right ... at all.
Oops, confused the two locks.
Still though, wouldn't the scan work simply not do anything?
johannes
next prev parent reply other threads:[~2010-04-06 9:08 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-06 8:54 [PATCH] mac80211: check whether scan is in progress before queueing scan_work Teemu Paasikivi
2010-04-06 9:06 ` Johannes Berg
2010-04-06 9:08 ` Johannes Berg [this message]
2010-04-06 10:16 ` Teemu Paasikivi
2010-04-06 10:27 ` Johannes Berg
2010-04-06 10:29 ` Johannes Berg
2010-04-06 11:05 ` Teemu Paasikivi
2010-04-06 16:23 ` Dan Williams
2010-04-06 17:17 ` Johannes Berg
2010-04-06 18:07 ` Dan Williams
2010-04-07 6:09 ` Teemu Paasikivi
2010-04-09 8:09 ` Johannes Berg
-- strict thread matches above, loose matches on Subject: below --
2010-04-09 10:07 Teemu Paasikivi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1270544880.3929.4.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=ext-teemu.3.paasikivi@nokia.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.