All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ben Hutchings <bhutchings@solarflare.com>
To: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org, gospo@redhat.com,
	Alexander Duyck <alexander.h.duyck@intel.com>
Subject: Re: [net-next-2.6 PATCH] igb: add support for reporting 5GT/s during probe on PCIe Gen2
Date: Sat, 10 Apr 2010 00:54:16 +0100	[thread overview]
Message-ID: <1270857256.2176.37.camel@localhost> (raw)
In-Reply-To: <20100409195246.30654.40319.stgit@localhost.localdomain>

On Fri, 2010-04-09 at 12:52 -0700, Jeff Kirsher wrote:
> From: Alexander Duyck <alexander.h.duyck@intel.com>
> 
> This change corrects the fact that we were not reporting Gen2 link speeds
> when we were in fact connected at Gen2 rates.
> 
> Signed-off-by: Alexander Duyck <alexander.h.duyck@intel.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
> ---
> 
>  drivers/net/igb/e1000_defines.h |    3 +++
>  drivers/net/igb/e1000_mac.c     |   19 ++++++++++++++++---
>  drivers/net/igb/igb_main.c      |    1 +
>  3 files changed, 20 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/net/igb/e1000_defines.h b/drivers/net/igb/e1000_defines.h
> index 31d24e0..8e440e8 100644
> --- a/drivers/net/igb/e1000_defines.h
> +++ b/drivers/net/igb/e1000_defines.h
> @@ -615,6 +615,9 @@
>  
>  #define PCIE_LINK_WIDTH_MASK         0x3F0
>  #define PCIE_LINK_WIDTH_SHIFT        4
> +#define PCIE_LINK_SPEED_MASK         0x0F
> +#define PCIE_LINK_SPEED_2500         0x01
> +#define PCIE_LINK_SPEED_5000         0x02
>  #define PCIE_DEVICE_CONTROL2_16ms    0x0005
[...]

These generic definitions belong in <linux/pci_regs.h>; in fact some of
it is already there.

Ben.

-- 
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.


  reply	other threads:[~2010-04-09 23:54 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-09 19:52 [net-next-2.6 PATCH] igb: add support for reporting 5GT/s during probe on PCIe Gen2 Jeff Kirsher
2010-04-09 23:54 ` Ben Hutchings [this message]
2010-04-13  9:58   ` David Miller
  -- strict thread matches above, loose matches on Subject: below --
2010-04-27 11:02 Jeff Kirsher
2010-04-27 19:55 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1270857256.2176.37.camel@localhost \
    --to=bhutchings@solarflare.com \
    --cc=alexander.h.duyck@intel.com \
    --cc=davem@davemloft.net \
    --cc=gospo@redhat.com \
    --cc=jeffrey.t.kirsher@intel.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.