From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from he.sipsolutions.net ([78.46.109.217]:37471 "EHLO sipsolutions.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751969Ab0DLHjN (ORCPT ); Mon, 12 Apr 2010 03:39:13 -0400 Subject: Re: [PATCH 1/2] mac80211: Use G mandatory rates in 2GHz band From: Johannes Berg To: Bruno Randolf Cc: linville@tuxdriver.com, linux-wireless@vger.kernel.org In-Reply-To: <20100412073658.28078.32155.stgit@tt-desk> References: <20100412073658.28078.32155.stgit@tt-desk> Content-Type: text/plain; charset="UTF-8" Date: Mon, 12 Apr 2010 09:39:08 +0200 Message-ID: <1271057948.3877.2.camel@jlt3.sipsolutions.net> Mime-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Mon, 2010-04-12 at 16:36 +0900, Bruno Randolf wrote: > This changes the mandatory (basic) rates in the 2GHz band to the ERP mandatory > rates (1, 2, 5.5, 11, 6, 12, 24Mbps - as defined in 802.11 section 19.1.) > instead of the "B" mode basic rate (1Mbps - why not 2Mbps too?). > > B-only drivers (are there any?) should still work with this change, since they > simply don't have the faster rates. The functional change is that we now > default to faster basic rates, but as far as i can tell this is only really > used in IBSS code (STAs have to adapt to their AP). > > BTW: Is there a way to configure mac80211 to B-only mode or G-only mode? When > this is the case this has to be revised... > > Signed-off-by: Bruno Randolf > --- > net/mac80211/util.c | 3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-) > > diff --git a/net/mac80211/util.c b/net/mac80211/util.c > index 2b75b4f..282bda9 100644 > --- a/net/mac80211/util.c > +++ b/net/mac80211/util.c > @@ -844,7 +844,8 @@ u32 ieee80211_mandatory_rates(struct ieee80211_local *local, > } > > if (band == IEEE80211_BAND_2GHZ) > - mandatory_flag = IEEE80211_RATE_MANDATORY_B; > + mandatory_flag = IEEE80211_RATE_MANDATORY_B | > + IEEE80211_RATE_MANDATORY_G; > else > mandatory_flag = IEEE80211_RATE_MANDATORY_A; NACK. This will do nothing in BSS mode, and will break IBSS mode talking to 11b devices. johannes