All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Steven J. Magnani" <steve@digidescorp.com>
To: monstr@monstr.eu
Cc: microblaze-uclinux@itee.uq.edu.au, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] microblaze: allow developer selection of STACKTRACE
Date: Wed, 14 Apr 2010 10:44:11 -0500	[thread overview]
Message-ID: <1271259851.2990.20.camel@iscandar.digidescorp.com> (raw)
In-Reply-To: <4BC5DE54.2010305@monstr.eu>

On Wed, 2010-04-14 at 17:25 +0200, Michal Simek wrote:
> Steven J. Magnani wrote:
> > Allow the developer to configure STACKTRACE to enable userland access to backtraces in /proc/NN/stack.
> > 
> > Signed-off-by: Steven J. Magnani <steve@digidescorp.com>
> > ---
> > diff -uprN a/arch/microblaze/Kconfig b/arch/microblaze/Kconfig
> > --- a/arch/microblaze/Kconfig	2010-04-09 21:52:36.000000000 -0500
> > +++ b/arch/microblaze/Kconfig	2010-04-12 22:16:01.000000000 -0500
> > @@ -136,6 +136,14 @@ config PROC_DEVICETREE
> >  	  an image of the device tree that the kernel copies from Open
> >  	  Firmware or other boot firmware. If unsure, say Y here.
> >  
> > +config PROC_BACKTRACE
> > +	bool "Support for kernel backtraces in /proc/NN/stack"
> > +	default n
> > +	select STACKTRACE
> > +	help
> > +	  This option adds a backtrace of the kernel stack to /proc/NN/stack.
> > +	  If unsure, say N here.
> > +
> 
> Why did you create new Kconfig option? /proc/NN/stack is there when you 
> enable stacktrace support. There is not necessary to enable any new option.
> 
> Or is there any other point which I am missing?

AFAICT STACKTRACE is an embedded option that isn't presented in the
menu. If all you want is /proc/NN/stack without the baggage of kmemleak,
tracing, etc., I didn't see a way to configure it.

This probably belongs somewhere more generic, maybe lib/Kconfig.debug?

Steve



  reply	other threads:[~2010-04-14 15:44 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-14  4:55 [PATCH 2/2] microblaze: allow developer selection of STACKTRACE Steven J. Magnani
2010-04-14 15:25 ` Michal Simek
2010-04-14 15:44   ` Steven J. Magnani [this message]
2010-04-14 16:49     ` Michal Simek
2010-04-14 16:57       ` Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1271259851.2990.20.camel@iscandar.digidescorp.com \
    --to=steve@digidescorp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=microblaze-uclinux@itee.uq.edu.au \
    --cc=monstr@monstr.eu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.