From: Pavel Roskin <proski@gnu.org>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Zhu Yi <yi.zhu@intel.com>,
linville@tuxdriver.com, linux-wireless@vger.kernel.org,
Samuel Ortiz <sameo@linux.intel.com>
Subject: Re: [PATCH 2/2] iwmc3200wifi: check sparse endianness annotations
Date: Fri, 16 Apr 2010 17:34:58 -0400 [thread overview]
Message-ID: <1271453698.16507.26.camel@mj> (raw)
In-Reply-To: <1271451466.8043.0.camel@jlt3.sipsolutions.net>
On Fri, 2010-04-16 at 22:57 +0200, Johannes Berg wrote:
> We've done it on other drivers -- we can't do it for all of the kernel
> because that would drown people in warnings, but for those drivers that
> _should_ be clean it ought to be fine to add it by default.
Oh, I see, there are several precedents.
That said, there are not many warnings added by __CHECK_ENDIAN__. In my
x86_64 configuration, sparse produces 2316 lines of output without
__CHECK_ENDIAN__ and 3526 lines with __CHECK_ENDIAN__, a 52% increase.
That's hardly "drowning".
Also, the warnings about endianess are perhaps the most useful of all
sparse warnings.
--
Regards,
Pavel Roskin
next prev parent reply other threads:[~2010-04-16 21:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-16 1:28 [PATCH 1/2] iwmc3200wifi: Fix sparse warnings Zhu Yi
2010-04-16 1:28 ` [PATCH 2/2] iwmc3200wifi: check sparse endianness annotations Zhu Yi
2010-04-16 20:55 ` Pavel Roskin
2010-04-16 20:57 ` Johannes Berg
2010-04-16 21:34 ` Pavel Roskin [this message]
2010-04-17 8:20 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1271453698.16507.26.camel@mj \
--to=proski@gnu.org \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=sameo@linux.intel.com \
--cc=yi.zhu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.