All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christophe Varoqui <christophe.varoqui@gmail.com>
To: device-mapper development <dm-devel@redhat.com>
Subject: Re: [PATCH] multipath_tools: add alias while printing checker_message
Date: Sat, 17 Apr 2010 13:17:46 +0200	[thread overview]
Message-ID: <1271503066.9079.21.camel@localhost> (raw)
In-Reply-To: <E463DF2B2E584B4A82673F53D62C2EF48D088D7E@cosmail01.lsi.com>

You're right,
Applied

On mar., 2010-04-13 at 09:21 -0600, Moger, Babu wrote:
> This patch adds alias while printing checker messages. 
> Example of current Checker message. 
> 
> Apr 11 04:03:53 mymachine multipathd: sde: rdac checker reports path is down
> 
> Most of the time "sde" is meaningless when debugging the past failures. 
> 
> This patch add alias before the checker message..  
> Example of the new message..
> 
> Apr 12 16:55:54 mymachine multipathd: mpathb: sde - rdac checker reports path is down
> 
> Signed-off-by: Babu Moger <babu.moger@lsi.com>
> Reviewed-by: Vijay Chauhan <Vijay.Chauhan@lsi.com>
> 
> ---
> --- multipath-tools/multipathd/main.c.orig	2010-04-12 13:58:27.000000000 -0500
> +++ multipath-tools/multipathd/main.c	2010-04-12 14:01:08.000000000 -0500
> @@ -61,7 +61,7 @@
>  #define CMDSIZE 160
>  
>  #define LOG_MSG(a,b) \
> -	if (strlen(b)) condlog(a, "%s: %s", pp->dev, b);
> +	if (strlen(b)) condlog(a, "%s: %s - %s", pp->mpp->alias, pp->dev, b);
>  
>  pthread_cond_t exit_cond = PTHREAD_COND_INITIALIZER;
>  pthread_mutex_t exit_mutex = PTHREAD_MUTEX_INITIALIZER;
> 
> 
> 
> 
> --
> dm-devel mailing list
> dm-devel@redhat.com
> https://www.redhat.com/mailman/listinfo/dm-devel

  reply	other threads:[~2010-04-17 11:17 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-13 15:21 [PATCH] multipath_tools: add alias while printing checker_message Moger, Babu
2010-04-17 11:17 ` Christophe Varoqui [this message]
2010-04-17 20:26   ` multipath blocking a single path making multipath -ll , lvm commands go to D state brem belguebli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1271503066.9079.21.camel@localhost \
    --to=christophe.varoqui@gmail.com \
    --cc=christophe.varoqui@opensvc.com \
    --cc=dm-devel@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.