From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jerone Young Subject: Re: [PATCH] ACPI: DMI init_set_sci_en_on_resume for multiple Lenovo ThinkPads Date: Tue, 20 Apr 2010 12:18:56 -0500 Message-ID: <1271783936.25170.131.camel@laptop> References: <20100420140314.GA5573@canonical.com> <1271782601.25170.105.camel@laptop> <20100420171415.GA9550@srcf.ucam.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: Received: from adelie.canonical.com ([91.189.90.139]:47611 "EHLO adelie.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754433Ab0DTRTD (ORCPT ); Tue, 20 Apr 2010 13:19:03 -0400 In-Reply-To: <20100420171415.GA9550@srcf.ucam.org> Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: Matthew Garrett Cc: Alex Chiang , lenb@kernel.org, colin.king@canonical.com, linux-acpi@vger.kernel.org, linux-kernel , stable@kernel.org On Tue, 2010-04-20 at 18:14 +0100, Matthew Garrett wrote: > On Tue, Apr 20, 2010 at 11:56:41AM -0500, Jerone Young wrote: > > Don't think this patch should go in as Lenovo is issuing a BIOS to > > address this issue. On these Thinkpads listed and more. Seems to add > > uneeded quirks in my opinion. > > > > Though some over all patch may be good for all machines. As Windows > > seems to be setting this bit on it's own. > > It's a perfectly safe workaround that's limited to a well-bounded set of > machines and fixes a pretty serious problem with them. While I'd prefer > my approach and then a removal of the existing quirk entries, Alex's > patch makes more sense for stable. The BIOS update is as yet unreleased, > requires either Windows or an optical drive (which some of these > machines don't have) and is a far from discoverable solution to the > issue. I could agree, but the only issue is if you go to the thinkpad-acpi or ibm-acpi mailing list they would probably disagree as there have been updates to the bios in the past required for proper functionality of Thinkpads ;-) .. the bios update methods have not changed since then for Thinkpads. Thanks, Jerone