All of lore.kernel.org
 help / color / mirror / Atom feed
From: <gregkh@suse.de>
To: jic23@cam.ac.uk,gregkh@suse.de,greg@kroah.com,linux-iio@vger.kernel.org
Subject: patch staging-iio-lis3l02dq-incorrect-ws-used-in-container-of-call.patch added to gregkh-2.6 tree
Date: Thu, 22 Apr 2010 17:13:20 -0700	[thread overview]
Message-ID: <12719816002587@kroah.org> (raw)
In-Reply-To: <4B99288C.3080601@cam.ac.uk>


This is a note to let you know that I've just added the patch titled

    Subject: staging: iio: lis3l02dq - incorrect ws used in container of =
call.

to my gregkh-2.6 tree.  Its filename is

    staging-iio-lis3l02dq-incorrect-ws-used-in-container-of-call.patch

This tree can be found at=20
    http://www.kernel.org/pub/linux/kernel/people/gregkh/gregkh-2.6/patch=
es/


>>From jic23@cam.ac.uk  Thu Apr 22 16:37:59 2010
From: Jonathan Cameron <jic23@cam.ac.uk>
Date: Thu, 11 Mar 2010 17:29:48 +0000
Subject: staging: iio: lis3l02dq - incorrect ws used in container of call=
.
To: Greg KH <greg@kroah.com>,  "linux-iio@vger.kernel.org" <linux-iio@vge=
r.kernel.org>
Message-ID: <4B99288C.3080601@cam.ac.uk>

The word oops comes to mind.  Original patch to merge the two work queues
in here (prior to Greg taking them into staging) changed the top half to
only use one of them and the bottom half to assume it was the other.

Currently causes a NULL pointer dereference if you enable any of the even=
ts
on an lis3l02dq. Just goes to show I need a few more regression tests.


Signed-of-by: Jonathan Cameron <jic23@cam.ac.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

---
 drivers/staging/iio/accel/lis3l02dq_core.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/drivers/staging/iio/accel/lis3l02dq_core.c
+++ b/drivers/staging/iio/accel/lis3l02dq_core.c
@@ -618,7 +618,7 @@ static int lis3l02dq_thresh_handler_th(s
 static void lis3l02dq_thresh_handler_bh_no_check(struct work_struct *wor=
k_s)
 {
 	struct iio_work_cont *wc
-		=3D container_of(work_s, struct iio_work_cont, ws_nocheck);
+		=3D container_of(work_s, struct iio_work_cont, ws);
 	struct lis3l02dq_state *st =3D wc->st;
 	u8 t;
=20

      reply	other threads:[~2010-04-23  0:13 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-11 17:29 [PATCH] staging:iio:lis3l02dq - incorrect ws used in container of call Jonathan Cameron
2010-04-23  0:13 ` gregkh [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=12719816002587@kroah.org \
    --to=gregkh@suse.de \
    --cc=greg@kroah.com \
    --cc=jic23@cam.ac.uk \
    --cc=linux-iio@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.