From: Bob Peterson <rpeterso@redhat.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH 1/2] gfs2_edit: Don't hijack bh->b_data in read_master_dir
Date: Tue, 5 Apr 2016 13:11:03 -0400 (EDT) [thread overview]
Message-ID: <1272159287.47934913.1459876263383.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <1459865009-14109-1-git-send-email-anprice@redhat.com>
----- Original Message -----
> read_master_dir() reads data that doesn't match the bh's metadata into
> bh->b_data, which confuses display() later when it checks whether
> re-reading the block is required. Use bread() in read_master_dir()
> instead to keep the bh consistent, and make sure read_superblock()
> doesn't leak the buffer earlier.
>
> Signed-off-by: Andrew Price <anprice@redhat.com>
> ---
Hi,
ACK
Regards,
Bob Peterson
Red Hat File Systems
prev parent reply other threads:[~2016-04-05 17:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-05 14:03 [Cluster-devel] [PATCH 1/2] gfs2_edit: Don't hijack bh->b_data in read_master_dir Andrew Price
2016-04-05 14:03 ` [Cluster-devel] [PATCH 2/2] mkfs.gfs2: Open the target device with O_EXCL Andrew Price
2016-04-05 14:14 ` Bob Peterson
2016-04-05 14:37 ` Andrew Price
2016-04-05 17:09 ` Bob Peterson
2016-04-05 17:11 ` Bob Peterson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1272159287.47934913.1459876263383.JavaMail.zimbra@redhat.com \
--to=rpeterso@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.