From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Clifton Subject: Patch review Date: Sun, 25 Apr 2010 22:28:22 +0100 Message-ID: <1272230902.26741.28.camel@pcjc2lap> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from ppsw-52.csi.cam.ac.uk (ppsw-52.csi.cam.ac.uk [131.111.8.152]) by gabe.freedesktop.org (Postfix) with ESMTP id 709499E7BA for ; Sun, 25 Apr 2010 14:28:27 -0700 (PDT) Received: from cpc2-cmbg11-0-0-cust250.cmbg.cable.ntl.com ([86.22.76.251]:45744 helo=[192.168.1.113]) by ppsw-52.csi.cam.ac.uk (smtp.hermes.cam.ac.uk [131.111.8.157]:465) with esmtpsa (LOGIN:pcjc2) (SSLv3:DHE-RSA-AES256-SHA:256) id 1O69NK-0005v8-Gz (Exim 4.70) for intel-gfx@lists.freedesktop.org (return-path ); Sun, 25 Apr 2010 22:28:26 +0100 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org To: "intel-gfx@lists.freedesktop.org" List-Id: intel-gfx@lists.freedesktop.org Hi guys, I've sent three patches to the list for review recently, and posed a question about possible buggy palette handling. Two of the patches I sent fix bugs (one "real", one a build issue), and there is a one clean-up. I've had no replies on any issue yet. I would appreciate if someone could take a quick look and ACK / NAK the patches. I'm only a technical user (Although I do some OSS software development in my free time), and it is somewhat disheartening when I've taken the extra steps to produce a patch to fix the issues, for them to be (seemingly) ignored. If you want me to go away and file bug-reports, and attach the patches, I'll do it, but these are simple issues - and if people would pick up and commit the patches I've sent, it saves me a lot of time fighting bugzilla. It was me who "discovered" the TV-out logic on the Cantiga platforms seem to require a "0" in the state-change detection enable bits, but I see I got no credit for that detective work in the eventual patch Zhao Yakui worked up once with access to the HW specs / BIOS code. PS.. Wouldn't it be nice to get some of that reference BIOS code opened up? Regards, -- Peter Clifton Electrical Engineering Division, Engineering Department, University of Cambridge, 9, JJ Thomson Avenue, Cambridge CB3 0FA Tel: +44 (0)7729 980173 - (No signal in the lab!) Tel: +44 (0)1223 748328 - (Shared lab phone, ask for me)