From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Michael Chan" Subject: Re: [PATCH v2] tg3: Fix INTx fallback when MSI fails Date: Mon, 26 Apr 2010 11:01:21 -0700 Message-ID: <1272304881.9950.19.camel@HP1> References: <201004161015.12089.adetsch@br.ibm.com> <20100421.161751.94080129.davem@davemloft.net> <201004261427.07099.adetsch@br.ibm.com> <20100426.111017.189698604.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Cc: "adetsch@br.ibm.com" , "netdev@vger.kernel.org" , "Matthew Carlson" To: "David Miller" Return-path: Received: from mms1.broadcom.com ([216.31.210.17]:4858 "EHLO mms1.broadcom.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752213Ab0DZSNq (ORCPT ); Mon, 26 Apr 2010 14:13:46 -0400 In-Reply-To: <20100426.111017.189698604.davem@davemloft.net> Sender: netdev-owner@vger.kernel.org List-ID: On Mon, 2010-04-26 at 11:10 -0700, David Miller wrote: > From: Andre Detsch > Date: Mon, 26 Apr 2010 14:27:07 -0300 > > > tg3: Fix INTx fallback when MSI fails > > > > MSI setup changes the value of irq_vec in struct tg3 *tp. > > This attribute must be taken into account and restored before > > we try to do a new request_irq for INTx fallback. > > > > In powerpc, the original code was leading to an EINVAL return within > > request_irq, because the driver was trying to use the disabled MSI > > virtual irq number instead of tp->pdev->irq. > > > > Signed-off-by: Andre Detsch > > Broadcom folks, I've already asked you to review Andre's original patch. > > If you can't be bothered to look at and ACK/NACK a simple fix like > this for 10 days, then I'm just going to apply Andre's patch as-is > since it looks right to me. > > If the idea was to bundle this up into a set of 15 patches you guys > already have ready to bomb at me, I absolutely do not want you guys to > operate that way. It doesn't work. You should be able to ACK a > simple patch like this as soon as possible so it can be integrated > upstream in the most expediant manner possible. > > Thanks. > Sorry, Matt just got back from vacation. I discussed with Andre earlier today to come up with the new v2 patch. So this patch has my: Acked-by: Michael Chan