From: Pavel Roskin <proski@gnu.org>
To: Felix Fietkau <nbd@openwrt.org>
Cc: linux-wireless <linux-wireless@vger.kernel.org>,
"John W. Linville" <linville@tuxdriver.com>,
Johannes Berg <johannes@sipsolutions.net>
Subject: Re: [PATCH] mac80211: fix handling of 4-address-mode in ieee80211_change_iface
Date: Mon, 26 Apr 2010 17:50:07 -0400 [thread overview]
Message-ID: <1272318607.22987.2.camel@mj> (raw)
In-Reply-To: <4BD5D34F.8080205@openwrt.org>
On Mon, 2010-04-26 at 19:54 +0200, Felix Fietkau wrote:
> A misplaced interface type check bails out too early if the interface
> is not in monitor mode. This patch moves it to the right place, so that
> it only covers changes to the monitor flags.
...
> + if (sdata->vif.type != NL80211_IFTYPE_MONITOR || !flags)
> + return 0;
> +
> sdata->u.mntr_flags = *flags;
> return 0;
> }
Perhaps you could write it in a more readable way:
if (sdata->vif.type == NL80211_IFTYPE_MONITOR && flags)
sdata->u.mntr_flags = *flags;
return 0;
Just an idea, not an objection.
--
Regards,
Pavel Roskin
next prev parent reply other threads:[~2010-04-26 21:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-26 17:54 [PATCH] mac80211: fix handling of 4-address-mode in ieee80211_change_iface Felix Fietkau
2010-04-26 21:50 ` Pavel Roskin [this message]
2010-04-26 22:26 ` [PATCH v2] " Felix Fietkau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1272318607.22987.2.camel@mj \
--to=proski@gnu.org \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=nbd@openwrt.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.