From: Thomas Hellstrom <thellstrom@vmware.com>
To: airlied@gmail.com
Cc: Thomas Hellstrom <thellstrom@vmware.com>,
dri-devel@lists.freedesktop.org
Subject: [PATCH 10/13] drm/vmwgfx: Some modesetting cleanups and fixes.
Date: Tue, 27 Apr 2010 19:45:42 +0200 [thread overview]
Message-ID: <1272390345-3655-11-git-send-email-thellstrom@vmware.com> (raw)
In-Reply-To: <1272390345-3655-10-git-send-email-thellstrom@vmware.com>
From: Jakob Bornecrantz <jakob@vmware.com>
Signed-off-by: Jakob Bornecrantz <jakob@vmware.com>
Signed-off-by: Thomas Hellstrom <thellstrom@vmware.com>
---
drivers/gpu/drm/vmwgfx/vmwgfx_ldu.c | 17 ++++-------------
1 files changed, 4 insertions(+), 13 deletions(-)
diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_ldu.c b/drivers/gpu/drm/vmwgfx/vmwgfx_ldu.c
index c4aa653..923c013 100644
--- a/drivers/gpu/drm/vmwgfx/vmwgfx_ldu.c
+++ b/drivers/gpu/drm/vmwgfx/vmwgfx_ldu.c
@@ -113,16 +113,6 @@ static int vmw_ldu_commit_list(struct vmw_private *dev_priv)
return 0;
}
- for (i = 0; i < lds->last_num_active; i++) {
- vmw_write(dev_priv, SVGA_REG_DISPLAY_ID, i);
- vmw_write(dev_priv, SVGA_REG_DISPLAY_IS_PRIMARY, !i);
- vmw_write(dev_priv, SVGA_REG_DISPLAY_POSITION_X, 0);
- vmw_write(dev_priv, SVGA_REG_DISPLAY_POSITION_Y, 0);
- vmw_write(dev_priv, SVGA_REG_DISPLAY_WIDTH, 0);
- vmw_write(dev_priv, SVGA_REG_DISPLAY_HEIGHT, 0);
- vmw_write(dev_priv, SVGA_REG_DISPLAY_ID, SVGA_ID_INVALID);
- }
-
if (!list_empty(&lds->active)) {
entry = list_entry(lds->active.next, typeof(*entry), active);
fb = entry->base.crtc.fb;
@@ -131,6 +121,10 @@ static int vmw_ldu_commit_list(struct vmw_private *dev_priv)
fb->bits_per_pixel, fb->depth);
}
+ /* Make sure we always show something */
+ vmw_write(dev_priv, SVGA_REG_NUM_GUEST_DISPLAYS,
+ lds->num_active ? lds->num_active : 1);
+
i = 0;
list_for_each_entry(entry, &lds->active, active) {
crtc = &entry->base.crtc;
@@ -146,9 +140,6 @@ static int vmw_ldu_commit_list(struct vmw_private *dev_priv)
i++;
}
- /* Make sure we always show something */
- vmw_write(dev_priv, SVGA_REG_NUM_GUEST_DISPLAYS, i ? i : 1);
-
BUG_ON(i != lds->num_active);
lds->last_num_active = lds->num_active;
--
1.6.2.5
next prev parent reply other threads:[~2010-04-27 17:46 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-27 17:45 [PATCH 0/13] vmwgfx update Thomas Hellstrom
2010-04-27 17:45 ` [PATCH 01/13] drm/vmwgfx: Assume larger framebuffer max size Thomas Hellstrom
2010-04-27 17:45 ` [PATCH 02/13] drm/vmwgfx: Fix single framebuffer detection Thomas Hellstrom
2010-04-27 17:45 ` [PATCH 03/13] drm/vmwgfx: Make sure to unpin old and pin new framebuffer Thomas Hellstrom
2010-04-27 17:45 ` [PATCH 04/13] drm/vmwgfx: Add kernel throttling support. Bump minor Thomas Hellstrom
2010-04-27 17:45 ` [PATCH 05/13] drm/vmwgfx: Get connector status from detection function Thomas Hellstrom
2010-04-27 17:45 ` [PATCH 06/13] drm/vmwgfx: Support older hardware Thomas Hellstrom
2010-04-27 17:45 ` [PATCH 07/13] drm/vmwgfx: Reserve first part of VRAM for framebuffer Thomas Hellstrom
2010-04-27 17:45 ` [PATCH 08/13] drm/vmwgfx: Remove duplicate member from struct vmw_legacy_display_unit Thomas Hellstrom
2010-04-27 17:45 ` [PATCH 09/13] drm/vmwgfx: Don't use SVGA_REG_ENABLE in modesetting code Thomas Hellstrom
2010-04-27 17:45 ` Thomas Hellstrom [this message]
2010-04-27 17:45 ` [PATCH 11/13] drm/vmwgfx: Unpause overlay on update Thomas Hellstrom
2010-04-27 17:45 ` [PATCH 12/13] drm/vmwgfx: Print warnings in kernel log about bo pinning that fails Thomas Hellstrom
2010-04-27 17:45 ` [PATCH 13/13] drm/vmwgfx: Remove some leftover debug messages Thomas Hellstrom
2010-04-28 8:49 ` [PATCH 02/13] drm/vmwgfx: Fix single framebuffer detection Paulius Zaleckas
-- strict thread matches above, loose matches on Subject: below --
2010-05-28 9:21 [PATCH 0/13] vmwgfx update V2 Thomas Hellstrom
2010-05-28 9:21 ` [PATCH 01/13] drm/vmwgfx: Assume larger framebuffer max size Thomas Hellstrom
2010-05-28 9:21 ` [PATCH 02/13] drm/vmwgfx: Fix single framebuffer detection Thomas Hellstrom
2010-05-28 9:21 ` [PATCH 03/13] drm/vmwgfx: Make sure to unpin old and pin new framebuffer Thomas Hellstrom
2010-05-28 9:21 ` [PATCH 04/13] drm/vmwgfx: Add kernel throttling support. Bump minor Thomas Hellstrom
2010-05-28 9:21 ` [PATCH 05/13] drm/vmwgfx: Get connector status from detection function Thomas Hellstrom
2010-05-28 9:21 ` [PATCH 06/13] drm/vmwgfx: Support older hardware Thomas Hellstrom
2010-05-28 9:22 ` [PATCH 07/13] drm/vmwgfx: Reserve first part of VRAM for framebuffer Thomas Hellstrom
2010-05-28 9:22 ` [PATCH 08/13] drm/vmwgfx: Remove duplicate member from struct vmw_legacy_display_unit Thomas Hellstrom
2010-05-28 9:22 ` [PATCH 09/13] drm/vmwgfx: Don't use SVGA_REG_ENABLE in modesetting code Thomas Hellstrom
2010-05-28 9:22 ` [PATCH 10/13] drm/vmwgfx: Some modesetting cleanups and fixes Thomas Hellstrom
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1272390345-3655-11-git-send-email-thellstrom@vmware.com \
--to=thellstrom@vmware.com \
--cc=airlied@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.