From: Artem Bityutskiy <dedekind1@gmail.com>
To: Kevin Cernekee <cernekee@gmail.com>
Cc: linux-mtd@lists.infradead.org, dwmw2@infradead.org
Subject: Re: [PATCHv2] nanddump: Support 4096+218 and 4096+224 page sizes
Date: Wed, 05 May 2010 14:26:34 +0300 [thread overview]
Message-ID: <1273058794.3702.177.camel@localhost> (raw)
In-Reply-To: <947e853e5d1ba35a67546703267b0fabe59af110@localhost.localdomain>
On Mon, 2010-05-03 at 22:10 -0700, Kevin Cernekee wrote:
> Tested with Samsung K9GAG08U0D (4096+218).
>
> This fixes three additional problems found after the initial patch
> submission:
>
> 1) oobbuf was only 128B. Needs to be 256B now.
>
> 2) Random OOB data is output when nanddump hits a bad block, because
> the code was initializing readbuf instead.
>
> 3) When using "-p", random data is displayed for bytes 218-223 since
> the OOB does not end on a 16B boundary.
>
> Signed-off-by: Kevin Cernekee <cernekee@gmail.com>
Does not apply to the latest mtd-utils:
Applying: nanddump: Support 4096+218 and 4096+224 page sizes
error: patch failed: nanddump.c:209
error: nanddump.c: patch does not apply
Patch failed at 0001 nanddump: Support 4096+218 and 4096+224 page sizes
When you have resolved this problem run "git am -i --resolved".
If you would prefer to skip this patch, instead run "git am -i --skip".
To restore the original branch and stop patching run "git am -i --abort".
[dedekind@eru mtd-utils]$ patch -p1 < .git/rebase-apply/patch
patching file nanddump.c
Hunk #2 FAILED at 212.
Hunk #3 succeeded at 359 (offset 2 lines).
1 out of 3 hunks FAILED -- saving rejects to file nanddump.c.rej
--
Best Regards,
Artem Bityutskiy (Артём Битюцкий)
prev parent reply other threads:[~2010-05-05 11:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-04 5:10 [PATCHv2] nanddump: Support 4096+218 and 4096+224 page sizes Kevin Cernekee
2010-05-05 11:26 ` Artem Bityutskiy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1273058794.3702.177.camel@localhost \
--to=dedekind1@gmail.com \
--cc=cernekee@gmail.com \
--cc=dwmw2@infradead.org \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.