From: Pavel Roskin <proski@gnu.org>
To: ath9k-devel@lists.ath9k.org
Subject: [ath9k-devel] [PATCH] wireless: ath9k: Fix most coding style issues in ath9k This patch fixed up almost all coding style issues in the ath9k driver found by the ceckpatch.pl tool. Signed-off-by: Michael Sprecher <sprecher.m@gmail.com>
Date: Wed, 05 May 2010 14:57:19 -0400 [thread overview]
Message-ID: <1273085839.17700.3.camel@mj> (raw)
In-Reply-To: <1273080541-4680-1-git-send-email-sprecher.m@gmail.com>
On Wed, 2010-05-05 at 19:29 +0200, Michael Sprecher wrote:
> - if (padsize && skb->len>padpos+padsize) {
> + if (padsize && skb->len > padpos+padsize) {
There should be spaces around the plus. I didn't check the whole patch,
but I guess you should recheck it.
Besides, the description (after the first line) and the Signed-off-by
should be in the body of the message, not in the subject.
--
Regards,
Pavel Roskin
next prev parent reply other threads:[~2010-05-05 18:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-05 17:29 [ath9k-devel] [PATCH] wireless: ath9k: Fix most coding style issues in ath9k This patch fixed up almost all coding style issues in the ath9k driver found by the ceckpatch.pl tool. Signed-off-by: Michael Sprecher <sprecher.m@gmail.com> Michael Sprecher
2010-05-05 18:57 ` Pavel Roskin [this message]
-- strict thread matches above, loose matches on Subject: below --
2010-03-09 19:05 Michael Sprecher
2010-03-09 19:33 ` Luis R. Rodriguez
2010-04-08 18:41 ` John W. Linville
2010-04-08 19:12 ` Luis R. Rodriguez
[not found] ` <h2xf42143521004271314rb3a000arba8f9df5846e71ab@mail.gmail.com>
[not found] ` <j2of42143521004271315ice41b0edtabf0ed4914342d41@mail.gmail.com>
2010-04-27 20:21 ` Michael Sprecher
2010-04-27 21:05 ` Luis R. Rodriguez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1273085839.17700.3.camel@mj \
--to=proski@gnu.org \
--cc=ath9k-devel@lists.ath9k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.