All of lore.kernel.org
 help / color / mirror / Atom feed
From: Liam Girdwood <lrg@slimlogic.co.uk>
To: Peter Ujfalusi <peter.ujfalusi@nokia.com>,
	Jarkko Nikula <jhnikula@gmail.com>
Cc: alsa-devel@alsa-project.org,
	Mark Brown <broonie@opensource.wolfsonmicro.com>
Subject: Re: [PATCHv2] ASoC: tlv320aic3x: Add platform data and reset gpio handling
Date: Thu, 06 May 2010 09:17:55 +0100	[thread overview]
Message-ID: <1273133875.2992.14.camel@odin> (raw)
In-Reply-To: <201005061109.34734.peter.ujfalusi@nokia.com>

On Thu, 2010-05-06 at 11:09 +0300, Peter Ujfalusi wrote:
> On Wednesday 05 May 2010 13:02:03 ext Jarkko Nikula wrote:
> > Signed-off-by: Jarkko Nikula <jhnikula@gmail.com>
> > 
> > ---
> > 
> > v2:
> > 
> > - Removed added regulator_bulk_disable brain fart from aic3x_i2c_probe
> > - Added comment to gpio_reset number in aic3x_pdata
> 
> Would have been nice to have a commit message for this just in case.
> Something like this would do:
> Handle the reset GPIO within the codec driver in order to follow the startup 
> protocol for the tlv320aic3x codecs.
> 
> Can you Liam add this message (if Jarkko agrees)?

I can add a message if required.

Thanks

Liam
-- 
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk

  reply	other threads:[~2010-05-06  8:18 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-05 10:02 [PATCHv2] ASoC: tlv320aic3x: Add platform data and reset gpio handling Jarkko Nikula
2010-05-05 11:28 ` Mark Brown
2010-05-06  8:09 ` Peter Ujfalusi
2010-05-06  8:17   ` Liam Girdwood [this message]
2010-05-06  9:08     ` Peter Ujfalusi
2010-05-06  9:52       ` Mark Brown
2010-05-06 11:23         ` Peter Ujfalusi
2010-05-06 10:18   ` Jarkko Nikula
2010-05-06 14:05 ` Liam Girdwood

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1273133875.2992.14.camel@odin \
    --to=lrg@slimlogic.co.uk \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=jhnikula@gmail.com \
    --cc=peter.ujfalusi@nokia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.