From: Alex Williamson <alex.williamson@redhat.com>
To: KVM list <kvm@vger.kernel.org>
Subject: [PATCH] Fix segfault after device assignment hot remove
Date: Thu, 06 May 2010 12:58:12 -0600 [thread overview]
Message-ID: <1273172292.2616.72.camel@localhost> (raw)
We keep a qlist of assigned devices for irq updates, but we forgot to
remove entries from it if they're hot unplugged. This makes
assigned_dev_update_irqs() a timebomb that goes off when the guest is
rebooted.
Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
---
diff --git a/hw/device-assignment.c b/hw/device-assignment.c
index 1f13a6d..b9cc06f 100644
--- a/hw/device-assignment.c
+++ b/hw/device-assignment.c
@@ -1390,6 +1390,7 @@ static int assigned_exitfn(struct PCIDevice *pci_dev)
{
AssignedDevice *dev = DO_UPCAST(AssignedDevice, dev, pci_dev);
+ QLIST_REMOVE(dev, next);
deassign_device(dev);
free_assigned_device(dev);
return 0;
next reply other threads:[~2010-05-06 18:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-06 18:58 Alex Williamson [this message]
2010-05-11 14:31 ` [PATCH] Fix segfault after device assignment hot remove Marcelo Tosatti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1273172292.2616.72.camel@localhost \
--to=alex.williamson@redhat.com \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.