From: Artem Bityutskiy <dedekind1@gmail.com>
To: Sebastian Andrzej Siewior <sebastian@breakpoint.cc>
Cc: linux-mtd@lists.infradead.org
Subject: Re: [PATCH 2/4] UBI: introduce a new IO return code
Date: Fri, 07 May 2010 08:37:31 +0300 [thread overview]
Message-ID: <1273210651.2178.2.camel@localhost> (raw)
In-Reply-To: <20100506093440.GA15335@Chamillionaire.breakpoint.cc>
On Thu, 2010-05-06 at 11:34 +0200, Sebastian Andrzej Siewior wrote:
> * Artem Bityutskiy | 2010-05-03 13:13:00 [+0300]:
>
> >diff --git a/drivers/mtd/ubi/scan.c b/drivers/mtd/ubi/scan.c
> >index f52adca..65d03b5 100644
> >--- a/drivers/mtd/ubi/scan.c
> >+++ b/drivers/mtd/ubi/scan.c
> >@@ -745,7 +745,7 @@ static int process_eb(struct ubi_device *ubi, struct ubi_scan_info *si,
> > bitflips = 1;
> > else if (err == UBI_IO_PEB_EMPTY)
> > return add_to_list(si, pnum, UBI_SCAN_UNKNOWN_EC, &si->erase);
> >- else if (err == UBI_IO_BAD_HDR) {
> >+ else if (err = UBI_IO_BAD_HDR_READ || err == UBI_IO_BAD_HDR) {
>
> That part should be == and not = but you fix this in the next patch so I
> guess it is okay.
Fixed this in the wrong patch, I'll amend them and make sure this typo
goes away, thanks.
--
Best Regards,
Artem Bityutskiy (Артём Битюцкий)
next prev parent reply other threads:[~2010-05-07 5:39 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-03 10:12 [PATCH 0/4] UBI: improve empty flash handling Artem Bityutskiy
2010-05-03 10:12 ` [PATCH 1/4] UBI: simplify IO error codes - part 1 Artem Bityutskiy
2010-05-03 10:13 ` [PATCH 2/4] UBI: introduce a new IO return code Artem Bityutskiy
2010-05-06 9:34 ` Sebastian Andrzej Siewior
2010-05-07 5:37 ` Artem Bityutskiy [this message]
2010-05-03 10:13 ` [PATCH 3/4] UBI: introduce eraseblock counter variables Artem Bityutskiy
2010-05-03 10:13 ` [PATCH 4/4] UBI: improve corrupted flash handling Artem Bityutskiy
2010-05-06 9:52 ` [PATCH 0/4] UBI: improve empty " Sebastian Andrzej Siewior
2010-05-07 5:39 ` Artem Bityutskiy
2010-05-23 12:03 ` Artem Bityutskiy
2010-05-07 5:57 ` Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1273210651.2178.2.camel@localhost \
--to=dedekind1@gmail.com \
--cc=linux-mtd@lists.infradead.org \
--cc=sebastian@breakpoint.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.