Re: [RFC PATCHv2 1/7] HSI: Introducing HSI framework

[Carlos Chinea <carlos.chinea@nokia.com>]

Hi,

On Fri, 2010-05-07 at 17:26 +0200, ext Randy Dunlap wrote:
> On Fri,  7 May 2010 18:18:31 +0300 Carlos Chinea wrote:
> 
--[snip]--

> > diff --git a/drivers/hsi/Kconfig b/drivers/hsi/Kconfig
> > new file mode 100644
> > index 0000000..5af62ce
> > --- /dev/null
> > +++ b/drivers/hsi/Kconfig
> > @@ -0,0 +1,13 @@
> > +#
> > +# HSI driver configuration
> > +#
> > +menuconfig HSI
> > +	bool "HSI support"
> 
> Why is this bool instead of tristate?
> IOW, why can it not be built as a loadable module?
> 

Because, I have not implemented it yet. I was planning to do it later
on. But of course if it has to be there, I can add the module support
now.

> 
> > +	---help---
> > +	  The "High speed synchronous Serial Interface" is
> > +	  synchronous serial interface used mainly to connect
> > +	  application engines and cellular modems.
> > +
> > +if HSI
> > +
> > +endif # HSI
> > diff --git a/drivers/hsi/Makefile b/drivers/hsi/Makefile
> > new file mode 100644
> > index 0000000..b42b6cf
> > --- /dev/null
> > +++ b/drivers/hsi/Makefile
> > @@ -0,0 +1,4 @@
> > +#
> > +# Makefile for HSI
> > +#
> > +obj-$(CONFIG_HSI)	+= hsi.o
> 
> 
> ---
> ~Randy
> *** Remember to use Documentation/SubmitChecklist when testing your code ***

Br,
Carlos